Reviewed 29 of 29 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dan-hughes)

source/Private/Convert-CIDRToSubnetMask.ps1 line 9 at r1 (raw file):

        The array of addresses to that need to be converted.
#>
function Convert-CIDRToSubnetMask

If these are gonna be used in the MOF resources they need to be public functions, not private. Throughout where function is needed in MOF resource.

Code quote:

Convert-CIDRToSubnetMask

tests/TestHelpers/CommonTestHelper.psm1 line 210 at r1 (raw file):

    Test-NetworkTeamIntegrationEnvironment, `
    New-IntegrationLoopbackAdapter, `
    Remove-IntegrationLoopbackAdapter

Maybe here we should keep the export-modulemember since it says what to export even if there are more (private) functions in the module. 🤔

Code quote:

Export-ModuleMember -Function `
    Get-InvalidArgumentRecord, `
    Get-InvalidOperationRecord, `
    Test-NetworkTeamIntegrationEnvironment, `
    New-IntegrationLoopbackAdapter, `
    Remove-IntegrationLoopbackAdapter

Reviewed 24 of 45 files at r3, 55 of 66 files at r4, 4 of 4 files at r5, 1 of 2 files at r6, 11 of 11 files at r7, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dan-hughes)

tests/TestHelpers/CommonTestHelper.psm1 line 210 at r1 (raw file):

Should we uncomment the Export-ModuleMember block now?

tests/Integration/DSC_NetAdapterName.Integration.Tests.ps1 line 198 at r7 (raw file):

                $_.ConfigurationName -eq "$($script:dscResourceName)_Config_NameOnly"
            }
            

Looks like there are blank spaces on this line, don't we have a VS Code project setting for automatically trimming white space at end of line on save? 🤔

Code quote:

···········

source/Public/Get-DnsClientServerStaticAddress.ps1 line 16 at r7 (raw file):

        IP address family.
#>
function Get-DnsClientServerStaticAddress

I wonder if we should prefix each public function (commented on another module as well). If there is another exported command with the same name it will be a conflict, so wonder if we should prefix all commands with NetDsc or something to make sure they are unique?

What do you think?

Code quote:

Get-DnsClientServerStaticAddress

Reviewable status: 95 of 105 files reviewed, 2 unresolved discussions (waiting on @johlju)

tests/Integration/DSC_NetAdapterName.Integration.Tests.ps1 line 198 at r7 (raw file):

Fixed, not sure why vscode/PSSA was not picking this up. Checked all the integration test files.

source/Public/Get-DnsClientServerStaticAddress.ps1 line 16 at r7 (raw file):

Valid point, but instead of a prefix maybe a suffix instead? Then searching for usages across repos may be easier as atleast the start of the function name matches.