Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dsccommunity/SharePointDsc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.3.1-preview0001
Choose a base ref
...
head repository: dsccommunity/SharePointDsc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref

Commits on Oct 23, 2020

  1. Updated documentation

    ykuijs committed Oct 23, 2020
    Copy the full SHA
    30b1f71 View commit details
  2. Fixed issue in SPShellAdmins

    ykuijs committed Oct 23, 2020
    Copy the full SHA
    a7881b4 View commit details
  3. Fixed issue #1245

    ykuijs committed Oct 23, 2020
    Copy the full SHA
    77d102d View commit details
  4. Fixed issue #1244

    ykuijs committed Oct 23, 2020
    Copy the full SHA
    ec6a685 View commit details

Commits on Oct 27, 2020

  1. Fixing issue #1249

    ykuijs committed Oct 27, 2020
    Copy the full SHA
    673886f View commit details
  2. Fixes issue #1195

    ykuijs committed Oct 27, 2020
    Copy the full SHA
    e9b8836 View commit details

Commits on Nov 4, 2020

  1. Small logging update

    ykuijs committed Nov 4, 2020
    Copy the full SHA
    3ab86af View commit details

Commits on Nov 5, 2020

  1. Fixes #1241 and unit tests

    ykuijs committed Nov 5, 2020
    Copy the full SHA
    770bb67 View commit details

Commits on Nov 10, 2020

  1. Copy the full SHA
    33d6167 View commit details
  2. Formatting fixes

    jensotto committed Nov 10, 2020
    Copy the full SHA
    3db0481 View commit details
  3. Added SPFarm module tests

    ykuijs committed Nov 10, 2020
    Copy the full SHA
    f17a22b View commit details
  4. Merge pull request #1251 from ykuijs/bugfixes

    Bugfix PR
    ykuijs authored Nov 10, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    59229a7 View commit details
  5. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    6d5199c View commit details

Commits on Nov 11, 2020

  1. Merge pull request #1253 from jensotto/fix-error-when-no-workflow-is-…

    …configured
    
    SPWorkflowService: Fixed error when no workflow service is configured
    ykuijs authored Nov 11, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    cadc1e4 View commit details

Commits on Nov 13, 2020

  1. Copy the full SHA
    2304a6f View commit details
  2. Copy the full SHA
    2ce6024 View commit details
  3. Merge pull request #1257 from ykuijs/fix-TestSPDscIsADUser

    Added domain support to Test-SPDscIsADUser
    ykuijs authored Nov 13, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    2731f68 View commit details
  4. Copy the full SHA
    a8f5081 View commit details
  5. Merge pull request #1259 from ykuijs/bugfix

    Corrected diagnostic logging of credentials
    ykuijs authored Nov 13, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    2677ed9 View commit details

Commits on Nov 14, 2020

  1. Copy the full SHA
    4dfae30 View commit details

Commits on Nov 15, 2020

  1. Merge pull request #1260 from dsccommunity/updateChangelogAfterv4.4.0

    Updating ChangeLog since release of v4.4.0
    ykuijs authored Nov 15, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    3f1af01 View commit details

Commits on Nov 17, 2020

  1. Copy the full SHA
    0550fd0 View commit details

Commits on Nov 18, 2020

  1. Merge pull request #1261 from jensotto/fix-failing-cahcaccountconfigu…

    …ration-parameters
    
    SPWebAppPolicy: Fixed incorrect parameter usage
    ykuijs authored Nov 18, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    022c3b9 View commit details

Commits on Nov 25, 2020

  1. Copy the full SHA
    0ee95e8 View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    a028402 View commit details
  3. Copy the full SHA
    9dbb602 View commit details
  4. Copy the full SHA
    bbb96e4 View commit details

Commits on Nov 26, 2020

  1. Merge pull request #1266 from NikCharlebois/master

    SPAlternateUrl: Fixes Issue with Trailing Slash
    ykuijs authored Nov 26, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    afe7868 View commit details

Commits on Dec 3, 2020

  1. Copy the full SHA
    1ca07fb View commit details
  2. Merge pull request #1270 from Yvand/Yvand/donotset-ProviderSignOutUri…

    …-sp2013
    
    SPTrustedIdentityTokenIssuer: Do not set property ProviderSignOutUri in SP2013
    
    [skip ci]
    ykuijs authored Dec 3, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    9f8135b View commit details
  3. Copy the full SHA
    d2606a8 View commit details
  4. Fixed issue #1271

    ykuijs committed Dec 3, 2020
    Copy the full SHA
    602bac0 View commit details
  5. Fixing issue #1269

    ykuijs committed Dec 3, 2020
    Copy the full SHA
    a84a438 View commit details

Commits on Dec 8, 2020

  1. Fixing issue #1273

    ykuijs committed Dec 8, 2020
    Copy the full SHA
    b9aaa71 View commit details

Commits on Dec 9, 2020

  1. Updated pipeline scripts

    ykuijs committed Dec 9, 2020
    Copy the full SHA
    de8e69a View commit details
  2. Corrected build issues

    ykuijs committed Dec 9, 2020
    Copy the full SHA
    bd3b79e View commit details
  3. Corrected YAML issues

    ykuijs committed Dec 9, 2020
    Copy the full SHA
    0283197 View commit details
  4. YAML issue

    ykuijs committed Dec 9, 2020
    Copy the full SHA
    8559abe View commit details
  5. Copy the full SHA
    e3877e9 View commit details
  6. Corrected Stub path

    ykuijs committed Dec 9, 2020
    Copy the full SHA
    8d50984 View commit details

Commits on Dec 16, 2020

  1. SPUserProfileServiceApp - Changed MySiteHostLocation parameter mandat…

    …ory=$false
    
    SPUserProfileServiceApp
      - Changed MySiteHostLocation parameter mandatory=$false
      - Added validation to Set function for testing if SiteNamingConflictResolution parameter is defined then
        also MySiteHostLocation parameters has to be because it is a mandatory parameter in the parameter set of New-SPProfileServiceApplication when SiteNamingConflictResolution is used
      - Added "MySiteHostLocation" to Test-SPDscParameterState function in Test-TargetResource
    petepuu committed Dec 16, 2020
    Copy the full SHA
    59bb985 View commit details
  2. Update MSFT_SPUserProfileServiceApp.schema.mof

    Changed MySiteHostLocation parameter to not be mandatory
    petepuu committed Dec 16, 2020
    Copy the full SHA
    37a5e6a View commit details
  3. Copy the full SHA
    27489ea View commit details
  4. Pipeline update test

    ykuijs committed Dec 16, 2020
    Copy the full SHA
    b477c63 View commit details
  5. Pipeline test

    ykuijs committed Dec 16, 2020
    Copy the full SHA
    ed8be6e View commit details

Commits on Dec 17, 2020

  1. Updated gitattributes

    ykuijs committed Dec 17, 2020
    Copy the full SHA
    897096f View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    30dddb4 View commit details
  3. Copy the full SHA
    130a9b0 View commit details

Commits on Dec 18, 2020

  1. Copy the full SHA
    88c89f6 View commit details
  2. Merge pull request #1275 from petepuu/master

    SPUserProfileServiceApp: Changed MySiteHostLocation parameter to not be mandatory
    ykuijs authored Dec 18, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    333e119 View commit details
Showing 708 changed files with 72,308 additions and 12,593 deletions.
74 changes: 11 additions & 63 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,63 +1,11 @@
###############################################################################
# Set default behavior to automatically normalize line endings.
###############################################################################
* text=auto

###############################################################################
# Set default behavior for command prompt diff.
#
# This is need for earlier builds of msysgit that does not have it on by
# default for csharp files.
# Note: This is only used by command line
###############################################################################
#*.cs diff=csharp

###############################################################################
# Set the merge driver for project and solution files
#
# Merging from the command prompt will add diff markers to the files if there
# are conflicts (Merging from VS is not affected by the settings below, in VS
# the diff markers are never inserted). Diff markers may cause the following
# file extensions to fail to load in VS. An alternative would be to treat
# these files as binary and thus will always conflict and require user
# intervention with every merge. To do so, just uncomment the entries below
###############################################################################
#*.sln merge=binary
#*.csproj merge=binary
#*.vbproj merge=binary
#*.vcxproj merge=binary
#*.vcproj merge=binary
#*.dbproj merge=binary
#*.fsproj merge=binary
#*.lsproj merge=binary
#*.wixproj merge=binary
#*.modelproj merge=binary
#*.sqlproj merge=binary
#*.wwaproj merge=binary

###############################################################################
# behavior for image files
#
# image files are treated as binary by default.
###############################################################################
#*.jpg binary
#*.png binary
#*.gif binary

###############################################################################
# diff behavior for common document formats
#
# Convert binary document formats to text before diffing them. This feature
# is only available from the command line. Turn it on by uncommenting the
# entries below.
###############################################################################
#*.doc diff=astextplain
#*.DOC diff=astextplain
#*.docx diff=astextplain
#*.DOCX diff=astextplain
#*.dot diff=astextplain
#*.DOT diff=astextplain
#*.pdf diff=astextplain
#*.PDF diff=astextplain
#*.rtf diff=astextplain
#*.RTF diff=astextplain
# Needed for publishing of examples, build worker defaults to core.autocrlf=input.
* text eol=crlf

# Ensure any exe files are treated as binary
*.exe binary
*.jpg binary
*.xl* binary
*.pfx binary
*.png binary
*.dll binary
*.so binary
5 changes: 5 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# These owners will be the default owners for everything in
# the repo. Unless a later match takes precedence,
# @global-owner1 and @global-owner2 will be requested for
# review when someone opens a pull request.
* @ykuijs
63 changes: 0 additions & 63 deletions .github/ISSUE_TEMPLATE/Problem_with_resource.md

This file was deleted.

97 changes: 97 additions & 0 deletions .github/ISSUE_TEMPLATE/Problem_with_resource.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
name: Problem with a resource
description: If you have a problem, bug, or enhancement with a resource in this resource module.
labels: []
assignees: []
body:
- type: markdown
attributes:
value: |
Please prefix the issue title (above) with the resource name, e.g. 'ResourceName: Short description of my issue'!
Your feedback and support is greatly appreciated, thanks for contributing!
- type: textarea
id: description
attributes:
label: Problem description
description: Details of the scenario you tried and the problem that is occurring.
validations:
required: true
- type: textarea
id: logs
attributes:
label: Verbose logs
description: |
Verbose logs showing the problem. **NOTE! Sensitive information should be obfuscated.** _Will be automatically formatted as plain text._
placeholder: |
Paste verbose logs here
render: text
validations:
required: true
- type: textarea
id: configuration
attributes:
label: DSC configuration
description: |
The DSC configuration that is used to reproduce the issue (as detailed as possible). **NOTE! Sensitive information should be obfuscated.** _Will be automatically formatted as PowerShell code._
placeholder: |
Paste DSC configuration here
render: powershell
validations:
required: true
- type: textarea
id: suggestedSolution
attributes:
label: Suggested solution
description: Do you have any suggestions how to solve the issue?
validations:
required: true
- type: textarea
id: targetSPVersion
attributes:
label: SharePoint version and build
description: |
Please provide version and build information of the SharePoint Server the target node is running. _Will be automatically formatted as plain text._
placeholder: |
Add SharePoint Server information here
render: text
validations:
required: true
- type: textarea
id: targetNodeOS
attributes:
label: Operating system the target node is running
description: |
Please provide as much as possible about the target node, for example edition, version, build, and language. _Will be automatically formatted as plain text._
On OS with WMF 5.1 the following command can help get this information: `Get-ComputerInfo -Property @('OsName','OsOperatingSystemSKU','OSArchitecture','WindowsVersion','WindowsBuildLabEx','OsLanguage','OsMuiLanguages')`
placeholder: |
Add operating system information here
render: text
validations:
required: true
- type: textarea
id: targetNodePS
attributes:
label: PowerShell version and build the target node is running
description: |
Please provide the version and build of PowerShell the target node is running. _Will be automatically formatted as plain text._
To help with this information, please run this command: `$PSVersionTable`
placeholder: |
Add PowerShell information here
render: text
validations:
required: true
- type: textarea
id: moduleVersion
attributes:
label: SharePointDsc version
description: |
Please provide the version of the SharePointDsc module that was used. _Will be automatically formatted as plain text._
To help with this information, please run this command: `Get-Module -Name 'SharePointDsc' -ListAvailable | ft Name,Version,Path`
placeholder: |
Add module information here
render: text
validations:
required: true
21 changes: 0 additions & 21 deletions .github/ISSUE_TEMPLATE/Resource_proposal.md

This file was deleted.

39 changes: 39 additions & 0 deletions .github/ISSUE_TEMPLATE/Resource_proposal.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: New resource proposal
description: If you have a new resource proposal that you think should be added to this resource module.
title: "NewResourceName: New resource proposal"
labels: []
assignees: []
body:
- type: markdown
attributes:
value: |
Please replace `NewResourceName` in the issue title (above) with your proposed resource name.
Thank you for contributing and making this resource module better!
- type: textarea
id: description
attributes:
label: Resource proposal
description: Provide information how this resource will/should work and how it will help users.
validations:
required: true
- type: textarea
id: proposedProperties
attributes:
label: Proposed properties
description: |
List all the proposed properties that the resource should have (key, required, write, and/or read). For each property provide a detailed description, the data type, if a default value should be used, and if the property is limited to a set of values.
value: |
Property | Type qualifier | Data type | Description | Default value | Allowed values
--- | --- | --- | --- | --- | ---
PropertyName | Key | String | Detailed description | None | None
validations:
required: true
- type: textarea
id: considerations
attributes:
label: Special considerations or limitations
description: |
Provide any considerations or limitations you can think of that a contributor should take in account when coding the proposed resource, and or what limitations a user will encounter or should consider when using the proposed resource.
validations:
required: true
46 changes: 20 additions & 26 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,32 +1,28 @@
<!--
Thanks for submitting a Pull Request (PR) to this project.
Your contribution to this project is greatly appreciated!
Thanks for submitting a Pull Request (PR) to this project. Your contribution to this project
is greatly appreciated!
Please prefix the PR title with the resource name,
e.g. 'ResourceName: My short description'.
If this is a breaking change, then also prefix the PR title
with 'BREAKING CHANGE:',
Please prefix the PR title with the resource name, e.g. 'ResourceName: My short description'.
If this is a breaking change, then also prefix the PR title with 'BREAKING CHANGE:',
e.g. 'BREAKING CHANGE: ResourceName: My short description'.
You may remove this comment block, and the other comment blocks, but please
keep the headers and the task list.
You may remove this comment block, and the other comment blocks, but please keep the headers
and the task list.
-->

#### Pull Request (PR) description

<!--
Replace this comment block with a description of your PR.
Also, make sure you have updated the CHANGELOG.md, see the
task list below. An entry in the CHANGELOG.md is mandatory
for all PRs.
Replace this comment block with a description of your PR. Also, make sure you have updated the
CHANGELOG.md, see the task list below. An entry in the CHANGELOG.md is mandatory for all PRs.
-->

#### This Pull Request (PR) fixes the following issues

<!--
If this PR does not fix an open issue, replace this comment block with None.
If this PR resolves one or more open issues, replace this comment block with
a list of the issues using a GitHub closing keyword, e.g.:
If this PR does not fix an open issue, replace this comment block with None. If this PR
resolves one or more open issues, replace this comment block with a list of the issues using
a GitHub closing keyword, e.g.:
- Fixes #123
- Fixes #124
@@ -35,21 +31,19 @@
#### Task list

<!--
To aid community reviewers in reviewing and merging your PR, please take
the time to run through the below checklist and make sure your PR has
everything updated as required.
To aid community reviewers in reviewing and merging your PR, please take the time to run
through the below checklist and make sure your PR has everything updated as required.
Change to [x] for each task in the task list that applies to your PR.
For those task that don't apply to you PR, leave those as is.
Change to [x] for each task in the task list that applies to your PR. For those task that
don't apply to you PR, leave those as is.
-->

- [ ] Added an entry to the change log under the Unreleased section of the
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
- [ ] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).
- [ ] Resource documentation added/updated in README.md.
- [ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
- [ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based
help.
- [ ] Comment-based help added/updated.
- [ ] Localization strings added/updated in all localization files as appropriate.
- [ ] Examples appropriately added/updated.
12 changes: 9 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
output/

**.bak
*.local.*
!**/README.md
.kitchen/

*.suo
*.user
*.coverage
.vs
.psproj
.sln
output/*
node_modules
node_modules/*
markdownissues.txt
node_modules
package-lock.json
Loading