Changing a platform's movement_controller doesn't change a sensor's movement_controller.

[gawebb-dstl]

I think it is rare that the movement_controller property on a platform is changed. However it is worth noting that changing a platform's movement_controller doesn't change the attached sensors' movement_controller. I've a pasted a snippet below which demostrates this.

timestamp = datetime.datetime.now()
fixed_state = State(np.array([[2], [2], [0]]),
                    timestamp)
fixed = FixedMovable(states=fixed_state, position_mapping=(0, 1, 2))
platform = MovingPlatform(movement_controller=fixed)

platform.add_sensor(DummySensor())
assert platform.movement_controller is sensor.movement_controller

moving_state = State(np.array([[2], [1], [2], [-1], [2], [0]]), timestamp)
moving = MovingMovable(states=moving_state, position_mapping=(0, 2, 4), transition_model=None)

platform.movement_controller = moving

assert platform.movement_controller is sensor.movement_controller  # This fails/

[gawebb-dstl]

Option 1: Make the movement_controller property read only.

I currently prefer this option. If the platform had already started moving, replacing the movement_controller would be rewriting the platform's history.

[gawebb-dstl]

Option 2: Add a setter for the movement_controller property.

[gawebb-dstl]

What are your thoughts @erogers-dstl ?