Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DwellActionsGenerator action_from_value produces mirrored actions #1104

Open
csherman-dstl opened this issue Dec 9, 2024 · 0 comments · May be fixed by #1107
Open

DwellActionsGenerator action_from_value produces mirrored actions #1104

csherman-dstl opened this issue Dec 9, 2024 · 0 comments · May be fixed by #1107

Comments

@csherman-dstl
Copy link
Contributor

The action_from_value method in the DwellActionsGenerator compares the absolute value of the dwell_centre with the absolute value of the target_value. This can result in the wrong action being produced if the negative of the target value sits between the initial dwell and the target dwell.

E.g. A sensor has a dwell of -1. A task is created to make this sensor look at a dwell of 0.5. The resulting task would be produced to look at -0.5 (if the resolution of the generator produced a value sufficiently close to -0.5)

@csherman-dstl csherman-dstl linked a pull request Dec 11, 2024 that will close this issue
@csherman-dstl csherman-dstl linked a pull request Dec 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant