Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Remove package versions in User's Guide Installation #412

Open
22 tasks
bikegeek opened this issue Jan 4, 2024 · 9 comments
Open
22 tasks
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue METplotpy: General priority: high High Priority requestor: Community General Community requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work

Comments

@bikegeek
Copy link
Collaborator

bikegeek commented Jan 4, 2024

Describe the Task

The only version of relevance is the Python version. Maintaining versions in multiple locations will result in confusion if the documentation is inconsistent with the requirements.txt. Refer the user to the requirements.txt instead with instructions for pip and conda installation using the requirements.txt

N.B.

opencv-python is the package name for pip installation
opencv is the package name for conda installation

Time Estimate

1 day

Sub-Issues

Consider breaking the task down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@bikegeek bikegeek added type: task An actionable item of work priority: high High Priority requestor: Community General Community alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone METplotpy: General labels Jan 4, 2024
@bikegeek bikegeek self-assigned this Jan 4, 2024
@bikegeek bikegeek added this to the METplotpy-3.0.0 milestone Jan 4, 2024
@lisagoodrich
Copy link
Contributor

@bikegeek or @fisherhucar would you have a couple minutes to meet and get me up to speed on this? I'm free until 4pm today. Thanks!

@bikegeek
Copy link
Collaborator Author

bikegeek commented Feb 28, 2024 via email

@lisagoodrich
Copy link
Contributor

@bikegeek thanks for the clarification.
I just created a branch, Feature_412_remove_package_versions and I feel silly. I think this work has already been done. There is already a literal include in the develop branch. https://github.com/dtcenter/METplotpy/blob/develop/docs/Users_Guide/installation.rst.
Should I delete my branch and close the issue?
Or is there another place that also needs a "literal include"?
Thanks.

@bikegeek
Copy link
Collaborator Author

bikegeek commented Feb 29, 2024 via email

@jprestop
Copy link
Contributor

jprestop commented Mar 2, 2024

@lisagoodrich Let me know if you have any questions about this work. I understand what Minna is asking for, so if it is not clear to you, I should be able to help.

@bikegeek, can you please clarify one point? Are the links above the only ones you want changed or are there others that perhaps you didn't link to that you also want changed and we should check all others (with the exclusion of the physics tendency which needs the hard-coded version for one package)?

@bikegeek
Copy link
Collaborator Author

bikegeek commented Mar 4, 2024 via email

@jprestop
Copy link
Contributor

jprestop commented Mar 4, 2024

Perfect, @bikegeek! Thank you for letting us know!

@lisagoodrich
Copy link
Contributor

@bikegeek I spoke with @jprestop about this and I need some clarification on the packages list in Required Packages section of the Polar Ice Plot. Here is a link to my branch:
https://metplotpy.readthedocs.io/en/develop/Users_Guide/polar_plot.html#required-packages
Version numbers for the following packages, along with the packages themselves, are not listed in the requirements.txt file but are listed as requirements.
metplotpy
cartopy
pyproj
pyresample
pillow
@jprestop suggests I stop work on this now, until we hear back from you, as she
thinks we are likely to encounter this problem with the other plots as well.

@bikegeek
Copy link
Collaborator Author

bikegeek commented Mar 4, 2024 via email

@jprestop jprestop changed the title Remove package versions in User's Guide Installation Documentation: Remove package versions in User's Guide Installation May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue METplotpy: General priority: high High Priority requestor: Community General Community requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work
Projects
Status: 🟢 Ready
Development

No branches or pull requests

3 participants