CONTRIBUTING.md

Contributing

Glad your are interested in this project. Here I'll share how I develop this library, hopefully it will be helpfull for you to get start.

Background

This repo has two crates: duckdb and libduckdb-sys, which libduckdb-sys is the original binding for duckdb-c-api and duckdb is an ergonomic wrapper on libduckdb-sys.

Most user should use duckdb, but our development may happen in both of these components.

Development

duckdb-c-api

Some features are still not implemented in the c api, so we may need pull request in the [duckdb repo]((https://github.com/duckdb/duckdb).

# build duckdb
cd ~/github/
git clone [email protected]:duckdb/duckdb.git
cd duckdb
GEN=ninja make debug

Related logics:

• header file: https://github.com/duckdb/duckdb/blob/master/src/include/duckdb.h
• impl file: https://github.com/duckdb/duckdb/blob/master/src/main/duckdb-c.cpp
• test file: https://github.com/duckdb/duckdb/blob/master/test/api/capi/test_capi.cpp
• You can refer to one of my previous PR: duckdb/duckdb#1923

After make the change, we can build the repo and use it in duckdb-rs by:

# assume in macOS, you may need to change the file in other OS
# export library and header file
cd ~/github/duckdb
mkdir ~/duckdb-lib
cp src/include/duckdb.h build/debug/src/libduckdb.dylib ~/duckdb-lib/
# set lib dir
export DUCKDB_LIB_DIR=~/duckdb-lib
# set header dir
export DUCKDB_INCLUDE_DIR=~/duckdb-lib

libduckdb-sys

Use the exported library and header:

cd ~/github/duckdb-rs/crates/libduckdb-sys
cargo test --features buildtime_bindgen

Use the bundled header file:

cd ~/github/duckdb-rs/crates/libduckdb-sys
cargo test --features bundled

Currently in github actions, we always use the bundled file for testing. So if you change the header in duckdb-cpp repo, you need to make the PR merged and updated the bundled-file. You can generated the amalgamated file by:

cd ~/github/duckdb
mkdir -p build/amaldebug
python scripts/amalgamation.py
cp src/amalgamation/duckdb.cpp src/include/duckdb.h src/amalgamation/duckdb.hpp ../duckdb-rs/crates/libduckdb-sys/duckdb/

duckdb-rs

Use the exported library and header:

cd ~/github/duckdb-rs/
cargo test --features buildtime_bindgen -- --nocapture

Use the bundled header file:

cd ~/github/duckdb-rs
cargo test --features bundled -- --nocapture

Detect memory leaks:

cd ~/github/duckdb-rs
ASAN_OPTIONS=detect_leaks=1 ASAN_SYMBOLIZER_PATH=/usr/local/opt/llvm/bin/llvm-symbolizer cargo test --features bundled -- --nocapture

Update to new version

Everytime duckdb release to a new version, we also need to release a new version.

We can use the scripts to do the upgrades:

./upgrade.sh

Which use sed to update the version number and then call ./libduckdb-sys/upgrade.sh to generated new bindings.

We may need to fix any error as duckdb's c-api may have breaking changes occasionally.