Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Way Better Error Handling #41

Open
bh2smith opened this issue Mar 26, 2024 · 2 comments
Open

Way Better Error Handling #41

bh2smith opened this issue Mar 26, 2024 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@bh2smith
Copy link
Collaborator

bh2smith commented Mar 26, 2024

Currently our error handling is WEAK AF! Just look how crappy this is:

https://github.com/bh2smith/ts-dune-client/blob/abef0d0f8c31c07ccf461a4038b6e770ddb25360/src/types/error.ts#L1-L7

The docs specify error codes on each route and when they occur (e.g. execute query)

We should have Enums that capture all possible errors instead of the weak-ass error class linked above.

@bh2smith bh2smith added the enhancement New feature or request label Mar 26, 2024
@bh2smith bh2smith changed the title Better Error Handling Way Better Error Handling Mar 26, 2024
@bh2smith bh2smith added the help wanted Extra attention is needed label Mar 26, 2024
@golddydev
Copy link

Hi, @bh2smith
I'd love to contribute to this project.
But permission denied.
Is it open source but not open to contribution?

@bh2smith
Copy link
Collaborator Author

bh2smith commented Jun 2, 2024

Is it open source but not open to contribution?

Hey there! Glad to hear you're interested to contribute. I think you'll find the following guide on contributing to open source helpful:

https://git-scm.com/book/en/v2/GitHub-Contributing-to-a-Project

Essentially, fork the project, create a topic branch, make your changes in your own fork and then submit a pull request to the source repository.

Since I imagine you've already cloned this project, the easiest way to set yourself up locally is to

  1. Fork the project in GitHub UI.
  2. In your local clone, something like git remote set fork "link to your fork" etc... so you have both copies locally.

There are many guides out there to point your clone at your fork. Here is one

https://gist.github.com/ElectricRCAircraftGuy/8ca9c04924ac11a50d48c2061d28b090#

Looking forward to your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants