Greek font looks bad/rendering issue

[stimfrog]

[kero3009destiny]

Inter or Roboto can be a good fallback for Greek, pretty close to Montserrat.

[DeepeshKalura]

@duogenesis assigned this task to me.

We have to do simple task.

1. I will download inter and roboto first. then put in the assets folder.
2. There must a global theme file I will put that as a fallback where I found the greek.
3. I think it just need to do in one are and valla the issue is resolve I think.

[duogenesis]

@DeepeshKalura Fonts go in the assets/ directory. Fonts are loaded in App.tsx. You can replace Montserrat with Roboto entirely, if Roboto's license permits us to distribute the font with Duolicious.

[DeepeshKalura]

@duogenesis
Yeah thanks man but i predicted that. Since, you are using Montserrat, which is a Google Font, and Roboto is also a Google Font, I assume there shouldn't be any issues with the licensing.

However, I recommend verifying this information here: https://fonts.google.com/specimen/Roboto better then sorry

[duogenesis]

@DeepeshKalura License looks fine to me

[DeepeshKalura]

@DeepeshKalura Fonts go in the assets/ directory. Fonts are loaded in App.tsx. You can replace Montserrat with Roboto entirely, if Roboto's license permits us to distribute the font with Duolicious.

Hey man replace Montserrat with roboto entirely mean?

I was thinking to add new fonts roboto loadFonts and then in default text component ( might is the component ) make a roboto default and fallback montserrat.

I don't why we are removing Montserrat. I don't know where this image from by stimfrog from the codebase help me in that also

[duogenesis]

Hey man replace Montserrat with roboto entirely mean?

Yes

I was thinking to add new fonts roboto loadFonts and then in default text component ( might is the component ) make a roboto default and fallback montserrat.

That sounds right, except for the fallback

I don't why we are removing Montserrat

If we use Roboto, it'll do everything Montserrat does but better. So Montserrat won't be needed

I don't know where this image from by stimfrog from the codebase

It's not in the code base. It looks like he wrote some Greek text in the 'About' section of his Profile. By the way, I forgot to mention you'll need to update the font in components/default-text-input.tsx.

[DeepeshKalura]

@duogenesis Ok, so I am mostly correct for this time I will not be removing anything you will tag me in the code review stuff. Then I will start removing it if everything seems fine to you.

Rather I will create entirely new things separately and you check first tell me how you check also I think I will do it within 1 hour.

so I also change the component/default-text-input.tsx change ok

[duogenesis]

@DeepeshKalura Are you going to fork duolicious/duolicious-frontend and then raise a pull request which contains your changes?

[DeepeshKalura]

@duogenesis i already did and did some changes and reading codebase. LOL it first time seeing react-native code by the I am do mostly flutter for frontend