Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execution-core: Support unproven phoenix-transaction #2405

Open
moCello opened this issue Sep 16, 2024 · 0 comments · May be fixed by #2409 or #2414
Open

execution-core: Support unproven phoenix-transaction #2405

moCello opened this issue Sep 16, 2024 · 0 comments · May be fixed by #2409 or #2414

Comments

@moCello
Copy link
Member

moCello commented Sep 16, 2024

Summary

Support the generation of an unproven phoenix-transaction and its conversion into a "proven" phoenix-transaction.

Detailed Description

In the current state, it is only possible to generate proven phoenix-transactions, passing a prover. Creating an uproven transaction therefore is only possible by passing a "prover" that doesn't actually generate the proof but instead just pastes the circuit-bytes into the proof field of the transaction and later on, after the proof has been generated, replacing the circuit-bytes with the proof bytes. This means that an important and delicate part of the transaction handling is delegated to the enduser, placing unnecessary overhead on the generation of transactions and also opening the door for involuntarily invalid transactions.

Relevant Context

Being able to generate a transaction and generating the transaction proof non-simultaneously is important when delegating the proof generation.

Possible Solution

Add an UnprovenTransaction struct with a circuit field. And add a from_unproven method to the phoenix-transaction that takes an unproven transaction and some proof bytes and returns a Self.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant