From 0c37e959ce36e95302edb8d050334128572f1a53 Mon Sep 17 00:00:00 2001
From: Jules Belveze <32683010+JulesBelveze@users.noreply.github.com>
Date: Thu, 2 Jan 2025 10:31:55 +0100
Subject: [PATCH] [front] - fix: assistant details modal (#9685)

* [front/components/assistant] - refactor: replace ElementModal with Sheet component in AssistantDetails

 - Introduced useState hook for tracking the Sheet's open state and useEffect hook to set this state based on the assistantId
 - Updated AssistantDetails to use the Sheet component for modal functionality, enhancing the UX with a new sliding panel design
 - Removed the now-obsolete ElementModal import and related attributes in favor of Sheet related components and attributes

* [front/assistant] - refactor: streamline AssistantDetails component state management

 - Removed unused isOpen state variable and useEffect for setting modal open state
 - Modified conditionals to use optional chaining for cleaner access to agentConfiguration properties
 - Ensure Sheet component open state is dependent on the existence of an assistantId
 - Conditional rendering of the AssistantUsageSection now checks for the existence of agentConfiguration directly
---
 .../components/assistant/AssistantDetails.tsx | 73 ++++++++++---------
 1 file changed, 40 insertions(+), 33 deletions(-)

diff --git a/front/components/assistant/AssistantDetails.tsx b/front/components/assistant/AssistantDetails.tsx
index 39cb30e59b95..e9e0deb58b55 100644
--- a/front/components/assistant/AssistantDetails.tsx
+++ b/front/components/assistant/AssistantDetails.tsx
@@ -1,9 +1,13 @@
 import {
   Avatar,
   ContentMessage,
-  ElementModal,
   InformationCircleIcon,
   Page,
+  Sheet,
+  SheetContainer,
+  SheetContent,
+  SheetHeader,
+  SheetTitle,
 } from "@dust-tt/sparkle";
 import type { AgentConfigurationScope, WorkspaceType } from "@dust-tt/types";
 import { useCallback, useState } from "react";
@@ -52,26 +56,24 @@ export function AssistantDetails({
     [doUpdateScope]
   );
 
-  if (!agentConfiguration) {
-    return <></>;
-  }
-
   const DescriptionSection = () => (
     <div className="flex flex-col gap-5">
       <div className="flex flex-col gap-3 sm:flex-row">
         <Avatar
           name="Assistant avatar"
-          visual={agentConfiguration.pictureUrl}
+          visual={agentConfiguration?.pictureUrl}
           size="lg"
         />
         <div className="flex grow flex-col gap-1">
           <div
             className={classNames(
               "font-bold text-foreground",
-              agentConfiguration.name.length > 20 ? "text-md" : "text-lg"
+              agentConfiguration?.name && agentConfiguration.name.length > 20
+                ? "text-md"
+                : "text-lg"
             )}
-          >{`@${agentConfiguration.name}`}</div>
-          {agentConfiguration.status === "active" && (
+          >{`@${agentConfiguration?.name ?? ""}`}</div>
+          {agentConfiguration?.status === "active" && (
             <SharingDropdown
               owner={owner}
               agentConfiguration={agentConfiguration}
@@ -83,7 +85,7 @@ export function AssistantDetails({
           )}
         </div>
       </div>
-      {agentConfiguration.status === "active" && (
+      {agentConfiguration?.status === "active" && (
         <AssistantDetailsButtonBar
           owner={owner}
           agentConfiguration={agentConfiguration}
@@ -91,7 +93,7 @@ export function AssistantDetails({
         />
       )}
 
-      {agentConfiguration.status === "archived" && (
+      {agentConfiguration?.status === "archived" && (
         <ContentMessage
           variant="amber"
           title="This assistant has been deleted."
@@ -103,18 +105,20 @@ export function AssistantDetails({
       )}
 
       <div className="text-sm text-foreground">
-        {agentConfiguration.description}
+        {agentConfiguration?.description}
       </div>
-      <AssistantUsageSection
-        agentConfiguration={agentConfiguration}
-        owner={owner}
-      />
+      {agentConfiguration && (
+        <AssistantUsageSection
+          agentConfiguration={agentConfiguration}
+          owner={owner}
+        />
+      )}
       <Page.Separator />
     </div>
   );
 
   const InstructionsSection = () =>
-    agentConfiguration.instructions ? (
+    agentConfiguration?.instructions ? (
       <div className="flex flex-col gap-2">
         <div className="text-lg font-bold text-element-800">Instructions</div>
         <ReadOnlyTextArea content={agentConfiguration.instructions} />
@@ -124,21 +128,24 @@ export function AssistantDetails({
     );
 
   return (
-    <ElementModal
-      openOnElement={agentConfiguration}
-      title=""
-      onClose={() => onClose()}
-      hasChanged={false}
-      variant="side-sm"
-    >
-      <div className="flex flex-col gap-5 pt-6 text-sm text-foreground">
-        <DescriptionSection />
-        <AssistantActionsSection
-          agentConfiguration={agentConfiguration}
-          owner={owner}
-        />
-        <InstructionsSection />
-      </div>
-    </ElementModal>
+    <Sheet open={!!assistantId} onOpenChange={onClose}>
+      <SheetContent size="lg">
+        <SheetHeader>
+          <SheetTitle />
+        </SheetHeader>
+        <SheetContainer>
+          {agentConfiguration && (
+            <div className="flex flex-col gap-5 pt-6 text-sm text-foreground">
+              <DescriptionSection />
+              <AssistantActionsSection
+                agentConfiguration={agentConfiguration}
+                owner={owner}
+              />
+              <InstructionsSection />
+            </div>
+          )}
+        </SheetContainer>
+      </SheetContent>
+    </Sheet>
   );
 }