From 29e271dd5c359deb32cd4b9ea7fe421a18977370 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daphn=C3=A9=20Popin?= <PopDaph@users.noreply.github.com>
Date: Wed, 27 Nov 2024 11:38:17 +0100
Subject: [PATCH] Ext: Various polish (#8937)

---
 .../assistants/AssistantFavorites.tsx         | 34 +++++++++----------
 .../conversation/AttachFragment.tsx           |  8 ++---
 .../app/src/components/input_bar/InputBar.tsx |  2 +-
 .../input_bar/InputBarCitations.tsx           |  2 +-
 .../input_bar/InputBarContainer.tsx           |  2 +-
 .../app/src/hooks/useFileUploaderService.ts   |  6 ++--
 6 files changed, 27 insertions(+), 27 deletions(-)

diff --git a/extension/app/src/components/assistants/AssistantFavorites.tsx b/extension/app/src/components/assistants/AssistantFavorites.tsx
index a72fa5ed0c4d9..b2dba8de11f55 100644
--- a/extension/app/src/components/assistants/AssistantFavorites.tsx
+++ b/extension/app/src/components/assistants/AssistantFavorites.tsx
@@ -39,9 +39,9 @@ export function AssistantFavorites() {
   return (
     <div className="h-full w-full pt-2 pb-12">
       <Page.SectionHeader title="Favorites" />
-      <div className="relative grid w-full grid-cols-1 sm:grid-cols-2 gap-2">
-        {hasFavorites ? (
-          agentConfigurations.map(
+      {hasFavorites ? (
+        <div className="relative grid w-full grid-cols-1 sm:grid-cols-2 gap-2">
+          {agentConfigurations.map(
             ({ sId, name, pictureUrl, lastAuthors, description }) => (
               <AssistantPreview
                 key={sId}
@@ -54,20 +54,20 @@ export function AssistantFavorites() {
                 hasAction={false}
               />
             )
-          )
-        ) : (
-          <div className="flex flex-col items-center pt-20 gap-4">
-            <p className="text-slate-400">
-              Your favorite assistants will appear here
-            </p>
-            <Button
-              label="Add favorites on Dust"
-              href={`${process.env.DUST_DOMAIN}`}
-              target="_blank"
-            />
-          </div>
-        )}
-      </div>
+          )}
+        </div>
+      ) : (
+        <div className="flex flex-col items-center pt-20 gap-4">
+          <p className="text-slate-400">
+            Your favorite assistants will appear here
+          </p>
+          <Button
+            label="Add favorites on Dust"
+            href={`${process.env.DUST_DOMAIN}`}
+            target="_blank"
+          />
+        </div>
+      )}
     </div>
   );
 }
diff --git a/extension/app/src/components/conversation/AttachFragment.tsx b/extension/app/src/components/conversation/AttachFragment.tsx
index d2dd001fa786e..b9cec864bec8d 100644
--- a/extension/app/src/components/conversation/AttachFragment.tsx
+++ b/extension/app/src/components/conversation/AttachFragment.tsx
@@ -28,7 +28,7 @@ export const AttachFragment = ({
       <div className="block sm:hidden">
         <Button
           icon={DocumentPlusIcon}
-          tooltip="Extract text from page and attach"
+          tooltip="Attach text from page"
           variant="outline"
           size="sm"
           className={attachPageBlinking ? "animate-[bgblink_200ms_3]" : ""}
@@ -43,7 +43,7 @@ export const AttachFragment = ({
       <div className="block sm:hidden">
         <Button
           icon={CameraIcon}
-          tooltip="Take page screenshot and attach"
+          tooltip="Attach page screenshot"
           variant="outline"
           size="sm"
           onClick={() =>
@@ -58,7 +58,7 @@ export const AttachFragment = ({
         <Button
           icon={DocumentPlusIcon}
           label="Add page text"
-          tooltip="Extract text from page and attach"
+          tooltip="Attach text from page"
           variant="outline"
           size="sm"
           className={attachPageBlinking ? "animate-[bgblink_200ms_3]" : ""}
@@ -74,7 +74,7 @@ export const AttachFragment = ({
         <Button
           icon={CameraIcon}
           label="Add page screenshot"
-          tooltip="Take page screenshot and attach"
+          tooltip="Attach page screenshot"
           variant="outline"
           size="sm"
           onClick={() =>
diff --git a/extension/app/src/components/input_bar/InputBar.tsx b/extension/app/src/components/input_bar/InputBar.tsx
index f90f5552a0e4c..9fa6036a81efe 100644
--- a/extension/app/src/components/input_bar/InputBar.tsx
+++ b/extension/app/src/components/input_bar/InputBar.tsx
@@ -269,7 +269,7 @@ export function AssistantInputBar({
           <div
             className={classNames(
               "relative flex w-full flex-1 flex-col items-stretch gap-0 self-stretch p-3",
-              "border-struture-200 border-t bg-white/90 backdrop-blur focus-within:border-structure-300",
+              "border-struture-200 border-t bg-white/90 backdrop-blur",
               "transition-all",
               "rounded-2xl border-b border-l border-r border-element-500 focus-within:border-action-300 focus-within:shadow-md focus-within:ring-1",
               isAnimating ? "duration-600 animate-shake" : "duration-300"
diff --git a/extension/app/src/components/input_bar/InputBarCitations.tsx b/extension/app/src/components/input_bar/InputBarCitations.tsx
index abaece207f50d..93f2d3ac1d0a0 100644
--- a/extension/app/src/components/input_bar/InputBarCitations.tsx
+++ b/extension/app/src/components/input_bar/InputBarCitations.tsx
@@ -37,7 +37,7 @@ export function InputBarCitations({
   }
 
   return (
-    <div className="mr-4 flex gap-2 overflow-auto border-b border-structure-300/50 pb-3 pt-4">
+    <div className="mr-4 flex gap-2 overflow-auto border-b border-structure-300/50 pb-3">
       {processContentFragments()}
     </div>
   );
diff --git a/extension/app/src/components/input_bar/InputBarContainer.tsx b/extension/app/src/components/input_bar/InputBarContainer.tsx
index 254404beae684..270d4f7687376 100644
--- a/extension/app/src/components/input_bar/InputBarContainer.tsx
+++ b/extension/app/src/components/input_bar/InputBarContainer.tsx
@@ -119,7 +119,7 @@ export const InputBarContainer = ({
         </div>
       </div>
 
-      <div className="flex items-center justify-end space-x-1 mt-2">
+      <div className="flex items-center justify-end space-x-2 mt-2">
         <AttachFragment fileUploaderService={fileUploaderService} />
         <SplitButton
           size="sm"
diff --git a/extension/app/src/hooks/useFileUploaderService.ts b/extension/app/src/hooks/useFileUploaderService.ts
index ca333d0bf184f..2dad4c3d5f411 100644
--- a/extension/app/src/hooks/useFileUploaderService.ts
+++ b/extension/app/src/hooks/useFileUploaderService.ts
@@ -305,7 +305,7 @@ export function useFileUploaderService(conversationId?: string) {
 
     if (tabContentRes && tabContentRes.isErr()) {
       sendNotification({
-        title: "Cannot get tab content",
+        title: "Cannot get page content",
         description: tabContentRes.error.message,
         type: "error",
       });
@@ -320,7 +320,7 @@ export function useFileUploaderService(conversationId?: string) {
     if (includeContent) {
       if (!tabContent?.content) {
         sendNotification({
-          title: "Cannot get tab content",
+          title: "Cannot get page content",
           description: "No content found.",
           type: "error",
         });
@@ -371,7 +371,7 @@ export function useFileUploaderService(conversationId?: string) {
     if (includeCapture) {
       if (!tabContent?.captures) {
         sendNotification({
-          title: "Cannot get tab content",
+          title: "Cannot get page content",
           description: "No content found.",
           type: "error",
         });