From 3bc927ec2cd851406d7957399504017291b17bc9 Mon Sep 17 00:00:00 2001
From: Philippe Rolet <pr@dust.tt>
Date: Sat, 21 Dec 2024 18:06:43 +0100
Subject: [PATCH] [Keyword search] Index creation: remove previous alias option
 (#9594)

Description
---
1. add `is_write_index` to alias on index creation (required when
alias points to multiple indices
2. provide an arg to remove alias on previous index version

Risks
---
na

Deploy
---
update runbook
core
---
 core/bin/elasticsearch/create_index.rs | 39 ++++++++++++++++++++------
 1 file changed, 31 insertions(+), 8 deletions(-)

diff --git a/core/bin/elasticsearch/create_index.rs b/core/bin/elasticsearch/create_index.rs
index e65e4cf119cd..f9d672d78544 100644
--- a/core/bin/elasticsearch/create_index.rs
+++ b/core/bin/elasticsearch/create_index.rs
@@ -2,7 +2,7 @@ use std::collections::HashMap;
 
 use clap::{Parser, ValueEnum};
 use dust::search_stores::search_store::ElasticsearchSearchStore;
-use elasticsearch::indices::{IndicesCreateParts, IndicesExistsParts};
+use elasticsearch::indices::{IndicesCreateParts, IndicesDeleteAliasParts, IndicesExistsParts};
 use http::StatusCode;
 
 #[derive(Parser, Debug, Clone, ValueEnum)]
@@ -32,13 +32,16 @@ struct Args {
 
     #[arg(long, help = "Skip confirmation")]
     skip_confirmation: bool,
+
+    #[arg(long, help = "Remove previous alias")]
+    remove_previous_alias: bool,
 }
 
 /*
  * Create an index in Elasticsearch for core
  *
  * Usage:
- * cargo run --bin create_index -- --index-name <index_name> --index-version <version> [--skip-confirmation]
+ * cargo run --bin create_index -- --index-name <index_name> --index-version <version> [--skip-confirmation] [--remove-previous-alias]
  *
  * Look for index settings and mappings in src/search_stores/indices/[index_name]_[version].settings.[region].json
  * Create the index with the given settings and mappings at [index_name]_[version], and set the alias to [index_name]
@@ -49,6 +52,14 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let args = Args::parse();
     let index_name = args.index_name;
     let index_version = args.index_version;
+    let remove_previous_alias = args.remove_previous_alias;
+
+    if remove_previous_alias && index_version == 1 {
+        return Err(anyhow::anyhow!("Cannot remove previous alias for version 1").into());
+    }
+    let index_fullname = format!("core.{}_{}", index_name, index_version);
+    let index_alias = format!("core.{}", index_name);
+    let index_previous_fullname = format!("core.{}_{}", index_name, index_version - 1);
 
     let url = std::env::var("ELASTICSEARCH_URL").expect("ELASTICSEARCH_URL must be set");
     let username =
@@ -61,9 +72,6 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     // create ES client
     let search_store = ElasticsearchSearchStore::new(&url, &username, &password).await?;
 
-    let index_fullname = format!("core.{}_{}", index_name, index_version);
-    let index_alias = format!("core.{}", index_name);
-
     // do not create index if it already exists
     let response = search_store
         .client
@@ -114,15 +122,17 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
         "settings": settings,
         "mappings": mappings,
         "aliases": {
-            index_alias.clone(): {}
+            index_alias.clone(): {
+                "is_write_index": true,
+            }
         }
     });
 
     // confirm creation
     if !args.skip_confirmation {
         println!(
-            "CHECK: Create index '{}' with alias '{}' in region '{}'? (y to confirm)",
-            index_fullname, index_alias, region
+            "CHECK: Create index '{}' with alias '{}' in region '{}' (remove previous alias: {})? (y to confirm)",
+            index_fullname, index_alias, region, remove_previous_alias
         );
         let mut input = String::new();
         std::io::stdin().read_line(&mut input).unwrap();
@@ -131,6 +141,19 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
         }
     }
 
+    // remove alias from old index
+    if remove_previous_alias {
+        search_store
+            .client
+            .indices()
+            .delete_alias(IndicesDeleteAliasParts::IndexName(
+                &[index_previous_fullname.as_str()],
+                &[index_alias.as_str()],
+            ))
+            .send()
+            .await?;
+    }
+
     // create index with settings, mappings and alias
     let response = search_store
         .client