From d463722a8a4ed05c5fd9e3d763fe6b8ccd6da352 Mon Sep 17 00:00:00 2001
From: Stanislas Polu <spolu@dust.tt>
Date: Thu, 22 Feb 2024 19:35:12 +0100
Subject: [PATCH] Revert "Link to assistant (assistant gallery) with panel open
 (#3895)" (#3902)

This reverts commit b20ab34a332966d347b1e9e5679a30e90f86ac88.
---
 front/pages/w/[wId]/assistant/assistants.tsx |  2 +-
 front/pages/w/[wId]/assistant/gallery.tsx    | 53 +++-----------------
 2 files changed, 8 insertions(+), 47 deletions(-)

diff --git a/front/pages/w/[wId]/assistant/assistants.tsx b/front/pages/w/[wId]/assistant/assistants.tsx
index 0a584126dfcf..33041cb6a67d 100644
--- a/front/pages/w/[wId]/assistant/assistants.tsx
+++ b/front/pages/w/[wId]/assistant/assistants.tsx
@@ -130,7 +130,7 @@ export default function MyAssistants({
               </Link>
             </Tooltip>
           )}
-          <Link href={`/w/${owner.sId}/assistant/gallery`}>
+          <Link href={`/w/${owner.sId}/assistant/gallery?flow=personal_add`}>
             <Button
               variant="primary"
               icon={BookOpenIcon}
diff --git a/front/pages/w/[wId]/assistant/gallery.tsx b/front/pages/w/[wId]/assistant/gallery.tsx
index 0093b026961d..c4dc63ebefdc 100644
--- a/front/pages/w/[wId]/assistant/gallery.tsx
+++ b/front/pages/w/[wId]/assistant/gallery.tsx
@@ -20,7 +20,7 @@ import { assertNever } from "@dust-tt/types";
 import type { InferGetServerSidePropsType } from "next";
 import { useRouter } from "next/router";
 import type { ComponentType } from "react";
-import { useEffect, useMemo, useState } from "react";
+import { useMemo, useState } from "react";
 
 import { AssistantDetails } from "@app/components/assistant/AssistantDetails";
 import { GalleryAssistantPreviewContainer } from "@app/components/assistant/GalleryAssistantPreviewContainer";
@@ -135,43 +135,11 @@ export default function AssistantsGallery({
       assertNever(orderBy);
   }
 
+  const [showDetails, setShowDetails] =
+    useState<LightAgentConfigurationType | null>(null);
   const [testModalAssistant, setTestModalAssistant] =
     useState<LightAgentConfigurationType | null>(null);
 
-  const [showDetails, setShowDetails] = useState<string | null>(null);
-
-  useEffect(() => {
-    const handleRouteChange = () => {
-      const assistantSId = router.query.assistantDetails ?? [];
-      if (assistantSId && typeof assistantSId === "string") {
-        setShowDetails(assistantSId);
-      } else {
-        setShowDetails(null);
-      }
-    };
-
-    // Initial check in case the component mounts with the query already set.
-    handleRouteChange();
-
-    router.events.on("routeChangeComplete", handleRouteChange);
-    return () => {
-      router.events.off("routeChangeComplete", handleRouteChange);
-    };
-  }, [router.query, router.events]);
-
-  const handleCloseAssistantDetails = () => {
-    const currentPathname = router.pathname;
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    const { assistantDetails, ...restQuery } = router.query;
-    void router.push(
-      { pathname: currentPathname, query: restQuery },
-      undefined,
-      {
-        shallow: true,
-      }
-    );
-  };
-
   const tabs: {
     label: string;
     current: boolean;
@@ -256,8 +224,8 @@ export default function AssistantsGallery({
     >
       <AssistantDetails
         owner={owner}
-        assistantId={showDetails}
-        onClose={handleCloseAssistantDetails}
+        assistantId={showDetails?.sId || null}
+        onClose={() => setShowDetails(null)}
         mutateAgentConfigurations={mutateAgentConfigurations}
       />
       {testModalAssistant && (
@@ -295,15 +263,8 @@ export default function AssistantsGallery({
                   owner={owner}
                   plan={plan}
                   agentConfiguration={a}
-                  onShowDetails={async () => {
-                    const href = {
-                      pathname: router.pathname,
-                      query: {
-                        ...router.query,
-                        assistantDetails: a.sId,
-                      },
-                    };
-                    await router.push(href);
+                  onShowDetails={() => {
+                    setShowDetails(a);
                   }}
                   onUpdate={() => {
                     void mutateAgentConfigurations();