fix(Zendesk) - improve error handling #9578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fetchFromZendeskWithRetries
, which should never be the place where we handle any kind of error whatsoever.fetchFromZendeskWithRetries
only rethrow errors, and from then handle accordingly in each function. For instance we can design a function that checks whether an article exist by fetching and catching 404 only.Risk
Deploy Plan