Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSNR of CUFED ? #8

Open
Lkinyuu opened this issue Oct 21, 2021 · 6 comments
Open

PSNR of CUFED ? #8

Lkinyuu opened this issue Oct 21, 2021 · 6 comments

Comments

@Lkinyuu
Copy link

Lkinyuu commented Oct 21, 2021

train as
python train.py --use_tb_logger --data_augmentation --max_iter 250 --loss_l1 --name train_masa_rec

but the best PSNR of CUFED only 27.31

@Lkinyuu
Copy link
Author

Lkinyuu commented Oct 21, 2021

but the PSNR/SSIM on paper is 27.54/0.814 although i havn't test the model, the psnr in test phase should be lower than train?

@SkyeLu
Copy link
Collaborator

SkyeLu commented Oct 21, 2021

Hi, did you stitch 4 references to one image while testing? If not, please refer to this issue: #2
You should try the following command:
python test.py --resume './pretrained_weights/masa_rec.pth' --testset TestSet_multi --name masa_TestSet_multi

@Lkinyuu
Copy link
Author

Lkinyuu commented Oct 21, 2021

Yeah,I have seen this issue. Actually,I haven’t done the test steps yet.But,as I said, the best PSNR I got in the eval phase during train is only 27.31,even lower than the PSNR in test on paper. In my cognition, the test PSNR should be lower than the eval PSNR.

@SkyeLu
Copy link
Collaborator

SkyeLu commented Oct 21, 2021

In the eval phase during training, we do not use four reference images, only one reference image is used for fast evaluation.

@wdmwhh
Copy link

wdmwhh commented Nov 23, 2021

Hi, I also try to reproduce the result. The best PSNR of CUFED is only 27.294 (for L1 and 27.466 for all references) in the 250 epochs.

@SkyeLu
Copy link
Collaborator

SkyeLu commented Dec 15, 2021

Hi, I also try to reproduce the result. The best PSNR of CUFED is only 27.294 (for L1 and 27.466 for all references) in the 250 epochs.

Hi, Different random seeds and experiment environments might lead to a slight difference between the replicated result and our reported result. Checkpoints from different epochs could also lead to different results (0.0x dB difference on PSNR is acceptable). You may try to run the code for multiple times using different random seeds, and also test with checkpoints from different epochs to get better results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants