Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot install in another folder #65

Closed
tjengbudi opened this issue Jan 29, 2021 · 10 comments
Closed

cannot install in another folder #65

tjengbudi opened this issue Jan 29, 2021 · 10 comments
Labels
Type: Bug Something isn't working as expected

Comments

@tjengbudi
Copy link

looks like it cannot change to another folder than home directory.
is there any hard coded home path besides in kiauh.sh?

i try to install in folder "installer" cause it will make my folder clean and not make confused.

@dw-0
Copy link
Owner

dw-0 commented Jan 29, 2021

It depends where you clone KIAUH into. You aren't forced to clone KIAUH in the home directory.
It should work in any directory or subdirectory you clone it into.
Or do you experience issues? If yes, please provide error messages.

@tjengbudi
Copy link
Author

yes i mean clone into another directory than home. i can clone the repository in another folder. but the script cannot work. cause it seeking in HOME directory.

i try with create folder ".kiauh" and failed. and then trying again with folder "installer"

the error after cloning and execute the script is like below

/home/octoprint/installer/kiauh/scripts/status.sh: line 3: cd: /home/octoprint/kiauh: No such file or directory
octoprint@HomeAssistant:~/installer/kiauh$


@dw-0
Copy link
Owner

dw-0 commented Jan 31, 2021

You are right. There is a hardcoded ${HOME} in the code. Thanks for pointing that out, i will fix the issue and check the script if there are any other spots where i made the same mistake.

@dw-0 dw-0 added the Type: Bug Something isn't working as expected label Jan 31, 2021
@dw-0 dw-0 closed this as completed in dc08d8e Jan 31, 2021
@tjengbudi
Copy link
Author

emm it is a little weird. i run the kiauh.sh in the separeted folder (let's say in the "installer" folder) and it is force to create the installation in the home root directory instead in the installer directory?

@dw-0
Copy link
Owner

dw-0 commented Jan 31, 2021

What installation are you talking about now exactly?
Klipper?

@dw-0 dw-0 reopened this Jan 31, 2021
@tjengbudi
Copy link
Author

sorry to make you confused about this...

i will told you what i have do

  1. i create folder "simple"
  2. make simple as active directory with "cd simple"
  3. do "git clone https://github.com/th33xitus/kiauh.git"
  4. and "./kiauh/kiauh.sh"

the installation of the klipper, moonraker, and fluidd (cause i install fluidd only) is in the home directory. (/home/octoprint/ in my case), when it supposed need to install in the simple directory (/home/octoprint/simple)

that's why i ask you, are this script force to install in the home directory? i already tried your newest project. it still force install the klipper, moonraker and the fluid in the home directory.

sorry for my bad english, install might means where you save the klipper, moonraker and fluid code

@dw-0
Copy link
Owner

dw-0 commented Jan 31, 2021

Now i get what you mean. 😄

And yes, klipper, moonraker and fluidd (and everything else) gets installed to the home directory. That is hardcoded and that won't get changed, i'm sorry.

@dw-0 dw-0 closed this as completed Feb 10, 2021
@kjkent
Copy link

kjkent commented Dec 12, 2023

As a feature request and alternative to allowing arbitrary install locations, perhaps KIAUH could respect the XDG Base Directory Specification if the requisite env vars were set. I may fork KIAUH to try to implement this, and would be happy to submit a PR if @dw-0 was open to it.

@dw-0
Copy link
Owner

dw-0 commented Dec 12, 2023

i would like to kinda refrain from using any specification in terms of files or directories to be honest. The issue is almost 3 years old and my view has changed a bit. So IF we allow different installation directories, how about NOT enforcing any specific (base) directory?

as some might have noticed, there is a kiauh rewrite ongoing. at a later stage, i plan to add support for custom installation directories. which should be rather easy to implement afterwards. there is an issue here: #372 that is also added to the milestones already.

@kjkent
Copy link

kjkent commented Dec 13, 2023

@dw-0 Thanks for the response. Yeah, there's good arguments for not enforcing a particular spec, and taking that approach means folk who want their files in a particular dir (like the XDG_XXXXX_HOME dirs) can do so anyway!

I'll check out the new linked issue, many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

3 participants