Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DbtCloud GET and POST methods needlessly raise exceptions cause loss of response info #3

Open
hans2520 opened this issue Mar 15, 2022 · 0 comments

Comments

@hans2520
Copy link

hans2520 commented Mar 15, 2022

The _get and _post methods of DbtCloud will use response.raise_for_status(), which will lock in users into the try/except paradigm, and furthermore will not include the original response object, which contains important details (such as the developer message or user message indicating the underlying root cause for failure).

Rather than use raise_for_status, simply allow callers to use it themselves or not after giving them a chance to parse/inspect the response contents for themselves.

hans2520 added a commit to hans2520/py-dbt-cloud that referenced this issue Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant