Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper exit status when an exception happens #29

Open
dwatteau opened this issue Apr 5, 2021 · 0 comments
Open

Improper exit status when an exception happens #29

dwatteau opened this issue Apr 5, 2021 · 0 comments
Assignees

Comments

@dwatteau
Copy link
Owner

dwatteau commented Apr 5, 2021

While trying to do this with ScummFont, in a directory where there was no CHAR_* files:

for file in CHAR_000? ; do
    scummfont o $file $file.bmp && scummfont i $file $file.bmp
done

this error happened:

ERROR: Cannot open font file
ERROR: Cannot open BMP file

The problem is that I used &&, so it should have stopped right after the first scummfont process. Looks like we're returning 0 even when an exception happens. That's quite dangerous for scripting…

Need to check all the tools for this behavior, and fix it.

@dwatteau dwatteau self-assigned this Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant