Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] When \255\001 is used inside a talkie sentence, the next two characters are misdecoded #36

Open
dwatteau opened this issue Sep 4, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@dwatteau
Copy link
Owner

dwatteau commented Sep 4, 2021

Happens with the original scummtr.exe as well.

For example with a talkie Monkey Island 2, such as Twang's French translation (scummtr -g monkey2 -w -of output.txt):

-\255\010\202\213\255\010\239\003\255\010\010\000\255\010\000\000\007J'aurais bien besoin\255\001de\016cette cr\138me revitalisante.\255\009\023\000
+\255\010\202\213\255\010\239\003\255\010\010\000\255\010\000\000\007J'aurais bien besoin\255\001\100\101\016cette cr\138me revitalisante.\255\009\023\000

Here, the de immediately after \255\001 inside the sentence is output as \100\101. That's still correct, but not very convenient.

(You can manually fix it and import it back without any problem, but it will get lost at the next output. Should be correctly output by default.)

Fixing this is potentially similar to what has been done in commit 3f040c6.

@dwatteau dwatteau added the bug Something isn't working label Sep 4, 2021
@dwatteau dwatteau self-assigned this Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant