You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(On top of PR #39, because it already removes more similar noise.)
clang-tidy appears to complain about some call to virtual functions inside some of our constructors and destructors:
src/common/file.cpp:68: Call to virtual method 'File::close' during destruction bypasses virtual dispatch
src/common/file.cpp:222: Call to virtual method 'File::read' during destruction bypasses virtual dispatch
src/common/file.cpp:292: Call to virtual method 'File::_zap' during destruction bypasses virtual dispatch
src/common/file.hpp:533: Call to virtual method 'SeqFile::close' during destruction bypasses virtual dispatch
src/ScummRp/block.cpp:956: Call to virtual method 'LFLFPack::_init' during construction bypasses virtual dispatch
src/ScummRp/block.cpp:1053: Call to virtual method 'LECFPack::_init' during construction bypasses virtual dispatch
src/ScummRp/block.cpp:2327: Call to virtual method 'OldRoomV1::_init' during construction bypasses virtual dispatch
src/ScummRp/block.cpp:2467: Call to virtual method 'OldRoomV2::_init' during construction bypasses virtual dispatch
src/ScummRp/block.cpp:2510: Call to virtual method 'OldRoomV2::_ooBX' during construction bypasses virtual dispatch
src/ScummRp/block.cpp:2636: Call to virtual method 'OldRoomV3::_init' during construction bypasses virtual dispatch
src/ScummRp/block.cpp:2679: Call to virtual method 'OldRoomV3::_ooBX' during construction bypasses virtual dispatch
src/ScummRp/toc.cpp:41: Call to virtual method 'TableOfContent::_zap' during construction bypasses virtual dispatch
src/ScummRp/toc.cpp:46: Call to virtual method 'TableOfContent::_zap' during destruction bypasses virtual dispatch
src/ScummRp/toc.cpp:414: Call to virtual method 'GlobalRoomIndex::_zap' during destruction bypasses virtual dispatch
I don't think I can fix this myself, though. Not enough knowledge of best C++ practices.
The text was updated successfully, but these errors were encountered:
(On top of PR #39, because it already removes more similar noise.)
clang-tidy appears to complain about some call to virtual functions inside some of our constructors and destructors:
I don't think I can fix this myself, though. Not enough knowledge of best C++ practices.
The text was updated successfully, but these errors were encountered: