Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

busclique finds cliques that aren't confirmed by the python polytime embedder #153

Open
boothby opened this issue Sep 4, 2020 · 3 comments

Comments

@boothby
Copy link
Collaborator

boothby commented Sep 4, 2020

edit: There's an issue in how the polytime embedder handles bad internal couplers

See #151 and #152. Seems to be impacting chimera graphs with a small number of bad edges

@boothby
Copy link
Collaborator Author

boothby commented Sep 4, 2020

Oops. I misread those logs. The issue is actually in the python polytime embedder, which isn't (yet) minorminer's responsibility. Leaving this open because I'll eventually want to fix that.

@arcondello
Copy link
Member

@boothby , potentially closed by dwavesystems/dwave-system#325?

@boothby
Copy link
Collaborator Author

boothby commented Sep 4, 2020

Yes-ish? There's still some value in that python code:

  1. it can handle arbitrary shore sizes; the c++ is limited to 8
  2. it can be used to sample from the space of maximum-size embeddings (with caveats), where the c++ is deterministic (with caveats)

So for now, I don't plan to remove it altogether.

@boothby boothby changed the title Bug or bad unit test in buclique.largest_clique_by_chainlength busclique finds cliques that aren't confirmed by the python polytime embedder Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants