-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why? What? How? #66
Labels
Comments
nelsonic
referenced
this issue
in dwyl/hits-nodejs
May 2, 2019
nelsonic
added a commit
that referenced
this issue
May 2, 2019
nelsonic
added a commit
that referenced
this issue
May 2, 2019
nelsonic
added a commit
that referenced
this issue
May 3, 2019
nelsonic
added a commit
that referenced
this issue
May 3, 2019
After running all the schema generators (above), 10 of the default tests are failing: |
nelsonic
added a commit
that referenced
this issue
May 4, 2019
nelsonic
added a commit
that referenced
this issue
May 4, 2019
nelsonic
added a commit
that referenced
this issue
May 5, 2019
nelsonic
added a commit
that referenced
this issue
May 5, 2019
nelsonic
added a commit
that referenced
this issue
May 5, 2019
Continue: https://hexdocs.pm/phoenix/contexts.html |
nelsonic
added a commit
that referenced
this issue
May 18, 2019
nelsonic
added a commit
that referenced
this issue
May 18, 2019
nelsonic
added a commit
that referenced
this issue
May 18, 2019
nelsonic
added a commit
that referenced
this issue
May 18, 2019
1 task
nelsonic
added a commit
that referenced
this issue
May 21, 2019
nelsonic
added a commit
that referenced
this issue
May 21, 2019
nelsonic
added a commit
that referenced
this issue
May 21, 2019
nelsonic
added a commit
that referenced
this issue
May 21, 2019
nelsonic
added a commit
that referenced
this issue
May 21, 2019
nelsonic
added a commit
that referenced
this issue
May 21, 2019
…ode which is not being executed ... 🙄 #66
nelsonic
added a commit
that referenced
this issue
May 21, 2019
…o that its easier to see which lines are not covered ... #66
nelsonic
added a commit
that referenced
this issue
May 21, 2019
nelsonic
added a commit
that referenced
this issue
May 21, 2019
nelsonic
added a commit
that referenced
this issue
May 21, 2019
nelsonic
added a commit
that referenced
this issue
May 21, 2019
nelsonic
added a commit
that referenced
this issue
May 21, 2019
nelsonic
added a commit
that referenced
this issue
May 21, 2019
nelsonic
added a commit
that referenced
this issue
May 22, 2019
nelsonic
added a commit
that referenced
this issue
May 22, 2019
nelsonic
added a commit
that referenced
this issue
May 22, 2019
If you are interested in a step-by-step tutorial/example, leave a comment on #74 |
This issue is now complete. Closing. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Why?
Phoenix is awesome and a phoenix/elixir implementation will be far more stable than the current (node.js) version which keeps crashing.
see: dwyl/product-roadmap#7 and #62, #63, #64 & #65
What?
Migrate the
node.js
Hits app https://github.com/dwyl/hitsto Phoenix using code written for https://github.com/dwyl/hits-elixir
Use a PostgreSQL database to store data so that we can run more interesting/advanced queries
How?
Going to document this as go but the the outline is:
see: https://hexdocs.pm/phoenix/installation.html#phoenix
mix phx.new hits
users
schema for storinguser
data:repos
schema for storingrepo
data:useragents
schema for storing user agent data:and HTML (views+templates)hits
for storing and viewing hit data:Create endpoint for "happy path"
/:user/:repository
Extract the metadata (
useragent
andip
address) from theconn
headers:https://github.com/dwyl/hits-elixir/blob/b2ed9c10aabc20a36f24c185a5f2a9831b1652d3/lib/hits.ex#L45-L54
INSERT
thehit
into the dabaseQuery PostgreSQL for the hit count for that repo How to SELECT COUNT(*) FROM hits WHERE repo_id = $1 #71
Create the SVG using string interpolation:
https://github.com/dwyl/hits-elixir/blob/b2ed9c10aabc20a36f24c185a5f2a9831b1652d3/lib/hits.ex#L29-L31
Return the SVG
Update screenshots to reflect change in TCP Port
8080
>4000
The text was updated successfully, but these errors were encountered: