Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example no js to reset input #88

Open
ndrean opened this issue Dec 2, 2022 · 5 comments
Open

example no js to reset input #88

ndrean opened this issue Dec 2, 2022 · 5 comments
Assignees
Labels
chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule.

Comments

@ndrean
Copy link

ndrean commented Dec 2, 2022

An example of code without the JS reset in the branch "example-no-js"

Changed the input and add value: @message (and add message in assigns on mount).
Add a phx-change to validate before save, and on save, reset assign message: ""

@nelsonic
Copy link
Member

nelsonic commented Dec 3, 2022

Seems like a good enhancement. Please PR update. 🙏

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. chore a tedious but necessary task often paying technical debt labels Dec 3, 2022
@nelsonic nelsonic assigned ndrean and unassigned nelsonic Dec 3, 2022
@ndrean
Copy link
Author

ndrean commented Dec 3, 2022

I suggest it is urgent to ...wait because the Phoenix API seems to be unstable at the moment. Wouldn't it be better to refactor only when the 1.17 will be released, and the docs updated?

@nelsonic
Copy link
Member

nelsonic commented Dec 4, 2022

@ndrean indeed. 💭
I wouldn't describe it as "unstable", Phoenix 1.6 is perfectly stable/reliable. 👌
Rather, changes will be required for v1.7, which I agree, is annoying/frustrating. 🙄

@nelsonic
Copy link
Member

nelsonic commented Dec 4, 2022

@ndrean
Copy link
Author

ndrean commented Dec 5, 2022

@nelsonic I am not sure I understand your point with the Phoenix-chat-example. In this case, you use "channels" whilst not at all with Liveview. Did I misunderstood something?

Then Git and I are not friends. I push --set-upstream on a branch but I can't see my code !? Anyway, I did not rewrote "Readme" so it is not a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule.
Projects
None yet
Development

No branches or pull requests

2 participants