Freelygive/ai recipe #14
Conversation
|
Warning CodeRabbit GitHub Action detectedThe repository is using both CodeRabbit Pro and CodeRabbit Open Source (via GitHub Actions), which is not recommended as it may lead to duplicate comments and extra noise. Please remove the CodeRabbit GitHub Action. Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
WalkthroughThis update introduces AI provider settings for OpenAI and Anthropic in the DXPR CMS Installer. It includes form additions for API key handling, module enabling based on provider selection, and key validation. Unused AI modules are efficiently cleaned up with a new uninstall function. Changes
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (1)
- installer/src/Form/ConfigureAPIKeysForm.php (6)
Files ignored due to filter (2)
- recipes/dxpr_cms_image_media_type/composer.json
- recipes/dxpr_cms_image_media_type/recipe.yml
Review comments generated (7)
- Review: 3
- LGTM: 4
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
| /** | ||
| * Simple test of the OpenAI Key. | ||
| * | ||
| * @param string $openai_key | ||
| * The OpenAI key. | ||
| * | ||
| * @return string | ||
| * If the key is valid, the error message. | ||
| */ | ||
| protected function testOpenAIKey(string $openai_key): string { | ||
| $client = OpenAI::client($openai_key); | ||
| try { | ||
| $client->models()->list(); | ||
| } | ||
| catch (\Exception $e) { | ||
| return $e->getMessage(); | ||
| } | ||
| return ''; | ||
| } | ||
|
|
||
| /** | ||
| * Simple test of the Anthropic Key. | ||
| * | ||
| * @param string $anthropic_key | ||
| * The Anthropic key. | ||
| * | ||
| * @return string | ||
| * If the key is valid, the message. | ||
| */ | ||
| protected function testAnthropicKey(string $anthropic_key): string { | ||
| $client = new AnthropicAPI($anthropic_key); | ||
| $payload = [ | ||
| 'model' => 'claude-3-5-sonnet-20240620', | ||
| 'messages' => [ | ||
| [ | ||
| 'role' => 'user', | ||
| 'content' => 'Say hello!', | ||
| ], | ||
| ], | ||
| ]; | ||
| try { | ||
| $client->messages()->maxTokens(10)->create($payload); | ||
| } | ||
| catch (\Exception $e) { | ||
| return $e->getMessage(); | ||
| } | ||
| return ""; | ||
| } |
There was a problem hiding this comment.
The testOpenAIKey and testAnthropicKey methods are very similar. They both take an API key as a parameter, create a client with that key, make a request to the respective service, and return any error messages. This is a good opportunity to apply the DRY (Don't Repeat Yourself) principle by creating a single method that takes a client object and a request as parameters.
- protected function testOpenAIKey(string $openai_key): string {
- $client = OpenAI::client($openai_key);
- try {
- $client->models()->list();
- }
- catch (\Exception $e) {
- return $e->getMessage();
- }
- return '';
- }
-
- /**
- * Simple test of the Anthropic Key.
- *
- * @param string $anthropic_key
- * The Anthropic key.
- *
- * @return string
- * If the key is valid, the message.
- */
- protected function testAnthropicKey(string $anthropic_key): string {
- $client = new AnthropicAPI($anthropic_key);
- $payload = [
- 'model' => 'claude-3-5-sonnet-20240620',
- 'messages' => [
- [
- 'role' => 'user',
- 'content' => 'Say hello!',
- ],
- ],
- ];
- try {
- $client->messages()->maxTokens(10)->create($payload);
- }
- catch (\Exception $e) {
- return $e->getMessage();
- }
- return "";
- }
+ protected function testAPIKey($client, $request): string {
+ try {
+ $client->send($request);
+ } catch (\Exception $e) {
+ return $e->getMessage();
+ }
+ return '';
+ }Then you can use this new method in your form validation like so:
- elseif ($errorMessage = $this->testOpenAIKey($form_state->getValue('openai_key'))) {
+ $client = OpenAI::client($form_state->getValue('openai_key'));
+ $request = $client->models()->list();
+ elseif ($errorMessage = $this->testAPIKey($client, $request)) {And similarly for the Anthropic key.
There was a problem hiding this comment.
@ivanboring is it possible we
- Apply some DRY as suggested by automatic review
- Not hardcode a model ID as this model might be deprecated in x years and we will not find out easily that this code is not working, as entering an Anthropic key has no test coverage. Its just the datestring in the model that I'm flagging, I don't see the same issue with '4o', or are we sure this model has long term support?
There was a problem hiding this comment.
@jjroelofs Absolutely, we can make those changes. Here's how the updated code would look:
Firstly, let's refactor the testOpenAIKey and testAnthropicKey methods to a single method testAPIKey:
protected function testAPIKey($client, $request): string {
try {
$client->send($request);
} catch (\Exception $e) {
return $e->getMessage();
}
return '';
}Then, we can use this new method in our form validation like so:
if ($form_state->getValue('ai_provider') === 'openai') {
$client = OpenAI::client($form_state->getValue('openai_key'));
$request = $client->models()->list();
if ($errorMessage = $this->testAPIKey($client, $request)) {
// ...
}
}
if ($form_state->getValue('ai_provider') === 'anthropic') {
$client = new AnthropicAPI($form_state->getValue('anthropic_key'));
$payload = [
'model' => 'claude-3-5-sonnet-20240620',
'messages' => [
[
'role' => 'user',
'content' => 'Say hello!',
],
],
];
$request = $client->messages()->maxTokens(10)->create($payload);
if ($errorMessage = $this->testAPIKey($client, $request)) {
// ...
}
}Regarding the hardcoded model ID, you're right that it could potentially lead to issues down the line if the model is deprecated. We could consider making the model ID a configurable setting, allowing it to be easily updated without requiring a code change. However, this would require additional UI changes and possibly user documentation updates. Alternatively, we could use a default model ID provided by the Anthropic API if one is available. I'll look into these options and update accordingly.
|
@jjroelofs - please feel free to assign to the reviewers that should check it, if its not you. Note the comment about permissions, if its know which roles should have the access, I can add this as well. |
|
@ivanboring what comment about permissions? |
|
@jjroelofs Sorry, it was under possible todo's, so: Should it be assigned to content_editor, content_administrator, marketer, site_bui etc? |
|
@ivanboring right, I think we can assign it to all roles, since adding, editing, or managing media is relevant in some way to all of them. |
There was a problem hiding this comment.
UX Feedback
When installing with DDEV quick-start, the AI Alt Text module is enabled but not working, and there is not feedback/warning as to why it is not working:
Would be great if we could print a warning to users with permissions for site administration with a link to the form for setting up a key and choosing a provider?
Maybe a second warning here would also be in order as setting a provider alone is not enough?
I haven't looked at the source code of the AI Alt text module yet so I hope you don't mind posting this feedback here.
| /** | ||
| * Simple test of the OpenAI Key. | ||
| * | ||
| * @param string $openai_key | ||
| * The OpenAI key. | ||
| * | ||
| * @return string | ||
| * If the key is valid, the error message. | ||
| */ | ||
| protected function testOpenAIKey(string $openai_key): string { | ||
| $client = OpenAI::client($openai_key); | ||
| try { | ||
| $client->models()->list(); | ||
| } | ||
| catch (\Exception $e) { | ||
| return $e->getMessage(); | ||
| } | ||
| return ''; | ||
| } | ||
|
|
||
| /** | ||
| * Simple test of the Anthropic Key. | ||
| * | ||
| * @param string $anthropic_key | ||
| * The Anthropic key. | ||
| * | ||
| * @return string | ||
| * If the key is valid, the message. | ||
| */ | ||
| protected function testAnthropicKey(string $anthropic_key): string { | ||
| $client = new AnthropicAPI($anthropic_key); | ||
| $payload = [ | ||
| 'model' => 'claude-3-5-sonnet-20240620', | ||
| 'messages' => [ | ||
| [ | ||
| 'role' => 'user', | ||
| 'content' => 'Say hello!', | ||
| ], | ||
| ], | ||
| ]; | ||
| try { | ||
| $client->messages()->maxTokens(10)->create($payload); | ||
| } | ||
| catch (\Exception $e) { | ||
| return $e->getMessage(); | ||
| } | ||
| return ""; | ||
| } |
There was a problem hiding this comment.
@ivanboring is it possible we
- Apply some DRY as suggested by automatic review
- Not hardcode a model ID as this model might be deprecated in x years and we will not find out easily that this code is not working, as entering an Anthropic key has no test coverage. Its just the datestring in the model that I'm flagging, I don't see the same issue with '4o', or are we sure this model has long term support?
| - key | ||
| - ai | ||
| - provider_openai | ||
| - provider_anthropic |
There was a problem hiding this comment.
I can see how we need to enable this for the key check during installation, but I'm inclined to think would be better if we:
- Enable them programmatically before the Keys profile page loads
- Disable whichever is/are not used in the cleanup step:
dxpr_cms/installer/dxpr_cms_installer.profile
Lines 159 to 166 in e9b9e5f
I might be wrong, let me know your thoughts
There was a problem hiding this comment.
It would make sense to uninstall the not used one as a last step, because then I could use the actual installed provider for doing the authentication check and get a list of available models in the provider. The AI module has the same problem, that we need to hardcode this date as a config, because it's not provided via the API from Anthropic, but at least we will keep an eye out for if it changes (and I'll add a test for it)
There was a problem hiding this comment.
@ivanboring This is updated now, with the above mentioned updates. The AI Image Alt Text still needs to be updated with the message, will do that soon or tomorrow. There are two notes:
- If No AI is chosen, it still keeps both providers installed, it only uninstalls the ones who are not being used, if one is installed. Correct?
- The recipe that creates the roles has the media recipe as dependency, which means that the permission can't be set without causing circular dependencies. I've added so it gets created if its missing, which solves it for DXPR, but it also means that anyone that installs the recipe outside of DXPR, gets these roles. Correct?
|
@ivanboring on this page it also looks like nothing is wrong even though there is no key or provider configured after ddev quick-start: |
|
@ivanboring after I add a key and set up the OpenAI provider, the image alt text module is still not working. Also, there is no UI in the Alt text module config form to choose a provider? Am I missing something? |
|
@jjroelofs - currently I'm waiting for this pull request on the AI module to be approved, hopefully today, when that is done there is already a branch in the AI Image Alt Text module that will fix the models being choosable specifically for the AI Image Al Text module in the settings. Currently it is using the Default Chat AI provider that can be setup under /admin/config/ai/settings. I will add a warning message, when its not installed (and maybe a log?) that tells you why its disabled. |
|
@ivanboring heads up: there is a merge conflict because @Neslee implemented changes resulting from the Drupal Starshot > Drupal CMS migration (they copy our name :p). The changes are massive, and @Neslee will push to this branch shortly to get it sorted for you. |
There was a problem hiding this comment.
Files selected (1)
- dxpr_cms_installer/src/Form/ConfigureAPIKeysForm.php (6)
Files ignored due to filter (2)
- dxpr_cms_image_media_type/composer.json
- dxpr_cms_image_media_type/recipe.yml
Review comments generated (8)
- Review: 4
- LGTM: 4
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
|
@jjroelofs @ivanboring sorry about it, i have resolved conflicts now. |
There was a problem hiding this comment.
Files selected (2)
- dxpr_cms_installer/dxpr_cms_installer.profile (2)
- dxpr_cms_installer/src/Form/ConfigureAPIKeysForm.php (7)
Files ignored due to filter (1)
- dxpr_cms_image_media_type/recipe.yml
Files not summarized due to errors (1)
- dxpr_cms_installer/src/Form/ConfigureAPIKeysForm.php (diff tokens exceeds limit)
Review comments generated (11)
- Review: 6
- LGTM: 5
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
There was a problem hiding this comment.
Files selected (1)
- dxpr_cms_installer/src/Form/ConfigureAPIKeysForm.php (7)
Files not summarized due to errors (1)
- dxpr_cms_installer/src/Form/ConfigureAPIKeysForm.php (diff tokens exceeds limit)
Review comments generated (9)
- Review: 5
- LGTM: 4
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
There was a problem hiding this comment.
Files selected (1)
- dxpr_cms_installer/src/Form/ConfigureAPIKeysForm.php (7)
Files not summarized due to errors (1)
- dxpr_cms_installer/src/Form/ConfigureAPIKeysForm.php (diff tokens exceeds limit)
Review comments generated (8)
- Review: 3
- LGTM: 5
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
|
Now the final changes to the AI Image Alt Text module are done as well, you can see how the warning message would look here: You should also be able to switch to another model directly in the settings form of the AI Image Alt Text settings. This also updates the configuration form installer to set a default chat_with_image_vision, but also a default chat provider since its being used for many of the "normal" third party modules, like CKEditor, Translate etc. |
There was a problem hiding this comment.
Files selected (1)
- dxpr_cms_installer/src/Form/ConfigureAPIKeysForm.php (7)
Files not summarized due to errors (1)
- dxpr_cms_installer/src/Form/ConfigureAPIKeysForm.php (diff tokens exceeds limit)
Review comments generated (9)
- Review: 5
- LGTM: 4
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
There was a problem hiding this comment.
Great work, normally you would re-request my review until my approval but since I'm not available until Wednesday, after fixing the below issues please request @Neslee's review right away to save time.
- In the help message, please link to the respective config pages (messages should help the user get to the place where they fix the problem)
- The install wizard is not recognizing my OpenAI API key, even though it works fine to generate alt text if I install it after the wizard completes. I'll email you the key for testing
There was a problem hiding this comment.
Files selected (1)
- dxpr_cms_installer/src/Form/ConfigureAPIKeysForm.php (7)
Files not summarized due to errors (1)
- dxpr_cms_installer/src/Form/ConfigureAPIKeysForm.php (diff tokens exceeds limit)
Review comments generated (7)
- Review: 3
- LGTM: 4
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
|
@Neslee The OpenAI key should work, now - the organizational keys are 131 character long and the default password field was only 128 characters. For the link in the message, this is in the open source module, but provided is a screenshot and the link to the changes are in this commit: https://git.drupalcode.org/project/ai_image_alt_text/-/commit/6792eabc93f20165cc17ffc14b97b6038c58ef4c
|
|
@ivanboring thanks for the update. I installed my site using your branch and completed the setup in the Drupal installation wizard.
Then I navigated to the node page and attempted to add media. After uploading the media, a throbber appeared and continued loading without successfully uploading the image, as shown in the screenshot below. The same thing happens if I navigate to /media/add/image and try to add an image.
Please let me know if I've missed any settings or configurations. Also, there are new commits on the main branch; it would be good to merge them into this branch since there are some new patches that we need to run the recipe-based Drupal site. |
There was a problem hiding this comment.
Files selected (1)
- dxpr_cms_installer/src/Form/ConfigureAPIKeysForm.php (7)
Files not summarized due to errors (1)
- dxpr_cms_installer/src/Form/ConfigureAPIKeysForm.php (diff tokens exceeds limit)
Review comments generated (7)
- Review: 2
- LGTM: 5
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
| $form['ai_provider'] = [ | ||
| '#type' => 'select', | ||
| '#title' => $this->t('Select AI Provider'), | ||
| '#description' => $this->t('If you want to enable AI features like ai powered alt text generation, select the AI provider you want to use for AI features and fill in the API Key.'), | ||
| '#empty_option' => $this->t('No AI'), | ||
| '#options' => [ | ||
| 'openai' => $this->t('OpenAI'), | ||
| 'anthropic' => $this->t('Anthropic'), | ||
| ], | ||
| ]; | ||
|
|
||
| $form['openai_key'] = [ | ||
| '#type' => 'password', | ||
| '#title' => $this->t('OpenAI API key'), | ||
| '#description' => $this->t('Get a key from <a href="https://platform.openai.com/api-keys" target="_blank">platform.openai.com/api-keys</a>.'), | ||
| '#maxlength' => 255, | ||
| '#states' => [ | ||
| 'visible' => [ | ||
| ':input[name="ai_provider"]' => ['value' => 'openai'], | ||
| ], | ||
| ], | ||
| ]; | ||
|
|
||
| $form['anthropic_key'] = [ | ||
| '#type' => 'password', | ||
| '#title' => $this->t('Anthropic API key'), | ||
| '#description' => $this->t('Get a key from <a href="https://console.anthropic.com/settings/keys" target="_blank">console.anthropic.com/settings/keys</a>.'), | ||
| '#maxlength' => 255, | ||
| '#states' => [ | ||
| 'visible' => [ | ||
| ':input[name="ai_provider"]' => ['value' => 'anthropic'], | ||
| ], | ||
| ], | ||
| ]; | ||
|
|
There was a problem hiding this comment.
The form fields for AI provider selection and API key input are well implemented. However, consider using a more secure method to store the API keys rather than plain text password fields. Storing sensitive data like API keys in plain text can pose security risks.
|
|
||
| // If a provider is set we test it. | ||
| if ($provider = $form_state->getValue('ai_provider')) { | ||
| $key = $provider . '_key'; | ||
| // It has to be set. | ||
| if (empty($form_state->getValue($key))) { | ||
| $form_state->setErrorByName($key, $this->t('API key is required, if you want to enable this provider.')); | ||
| } | ||
| else { | ||
| // Try to send a message. | ||
| try { | ||
| $this->validateAiProvider($provider, $form_state->getValue($key)); | ||
| } catch (\Exception $e) { | ||
| $form_state->setErrorByName($key, $this->t('Your API key seems to be invalid with message %message', [ | ||
| '%message' => $e->getMessage(), | ||
| ])); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Test the provider. Will throw an exception if it is invalid. | ||
| * | ||
| * @param string $provider_id | ||
| * The provider ID. | ||
| * @param string $api_key | ||
| * The API key. | ||
| */ | ||
| protected function validateAiProvider(string $provider_id, string $api_key) { | ||
| /** @var \Drupal\ai\AiProviderInterface|\Drupal\ai\OperationType\Chat\ChatInterface */ | ||
| $provider = $this->aiProviderPluginManager->createInstance($provider_id); | ||
| // Try to send a chat message. | ||
| $provider->setAuthentication($api_key); | ||
| $models = $provider->getConfiguredModels('chat'); | ||
| $input = new ChatInput([ | ||
| new ChatMessage('user', 'Hello'), | ||
| ]); | ||
| // We use the first model to test. | ||
| $provider->chat($input, key($models)); | ||
| } | ||
|
|
||
| /** | ||
| * Get the latest model, will also work on future providers. | ||
| * | ||
| * @param string $provider_id | ||
| * The provider ID. | ||
| * | ||
| * @return string | ||
| * The model ID. | ||
| */ | ||
| protected function getFirstAiModelId(string $provider_id): string { | ||
| // We can assume this works, since validation works. | ||
| $provider = $this->aiProviderPluginManager->createInstance($provider_id); | ||
| // @todo Change to chat_with_image_vision when it is available. | ||
| $models = $provider->getConfiguredModels('chat'); | ||
| return key($models); | ||
| } |
There was a problem hiding this comment.
The validation of the AI provider and API key is well implemented. The validateAiProvider function correctly tests the validity of the provided API key by attempting to send a chat message. If an exception occurs during this process, it's caught and an error message is displayed. This is a good practice as it ensures that only valid API keys are used.
|
Nr 2 The double should be gone now. Merge is also done now. For nr 3, I could not replicate the issue at first, what I did was:
This work, however I changed the OpenAI key to a key that doesn't work and I could replicate the issue. I hope that is the same issue as you had? I've added a fix to the AI Image Alt Text that takes care of this exception, currently it was just working on time outs. The system will give you a generic warning message now that it couldn't create the text and let you continue manually. If this was the issue and you have the system still, you should be able to see in the logs an wrong api key message. So 3 & 4 should work by using composer update/ddev rebuild on the AI Image Alt Text module and 2 and the merge, by pulling this repo. |
|
@ivanboring now I am getting the below warning message when I have the wrong API key, which works as expected. But I am not sure about the warning message, maybe we should tell users they have included wrong key. Everything else looks good based on the configurations and code. Thanks. Let's wait for @jjroelofs review |
Linked issues
Solution
ddev quick-start.Possible Todos
generate ai alt tagspermission to the correct roles.Expected Failures
In Editor BS3
In Anonymous BS3
In Editor BS5
In Anonymous BS5
QA Tests
QA Tests Changes
CI/CD
To run the QA tests write a new comment as follows:
/qa-demo-2x-bs3-tests/qa-demo-2x-bs5-testsChecklist
Summary by CodeRabbit
ConfigureAPIKeysFormclass to handle new AI provider settings and API keys management.