-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about discriminator input #22
Comments
@ssulun16 You are totally right. Cant believe I missed that. From section 2.2 in the paper:
I'm pretty busy with other projects right now, but would be awesome if you could make a PR that fixes this! Seems like it should just be a small tweak in the |
I made some other changes before so the code isn't very clean but I'll do that if I can find some time after I have a final version for myself. In the meantime I'll open issues if I find other problems so that it can help other people. |
I have fixed it but I also switched to Pytorch in the meantime, it is available in my repositories if anyone needs it. |
Hi Matt,
Thanks for the great code. According to the paper, the input to the discriminator is a sequence of frames (history of frames, and the next frame). If I understand your code correctly, the input to the discriminator is a single frame, which is only the next frame (either generated or from ground-truth). Is this right? If yes, wouldn't this prevent the discriminator to make use of the continuity in the video?
Thanks in advance.
The text was updated successfully, but these errors were encountered: