Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check consensus params after rollback #1126

Open
danwt opened this issue Oct 9, 2024 · 0 comments
Open

Check consensus params after rollback #1126

danwt opened this issue Oct 9, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@danwt
Copy link
Contributor

danwt commented Oct 9, 2024

The rollback cmd uses UpdateStateAfterCommit to update the consensus params and rollapp consensus params

https://github.com/dymensionxyz/dymint/blob/main/block/state.go#L127-L134

which won't work properly in this scenario:

Suppose dymint processes heights 1,2,3 and height 2 had an update
If you now rollback to height 1 then height 1 didn't contain and update so the local state in dymint will correspond to height 2 and 3 not height 1

@danwt danwt added the bug Something isn't working label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants