Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a different batch for da and for settlement #1171

Open
srene opened this issue Oct 28, 2024 · 2 comments
Open

create a different batch for da and for settlement #1171

srene opened this issue Oct 28, 2024 · 2 comments

Comments

@srene
Copy link
Contributor

srene commented Oct 28, 2024

right now the same batch struct is used when submitting to da and settlement, but there is data not marshalled and included when sent to da, like drs info and last batch, and it maybe confusing.

@danwt
Copy link
Contributor

danwt commented Jan 7, 2025

Makes sense, maybe one can embed the other?


Hub includes lastbatch, drsversion, revision
DA is just start height end height blocks and commits

@srene
Copy link
Contributor Author

srene commented Jan 8, 2025

it maybe a solution. imo its just a bit confusing that same struct name (da batch) mixes data that is only relevant to sl state updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants