-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deps] CMake is needed. #150
Comments
Hey JC, good to hear. Any idea which dependency needs cmake, or if this is a Mac/Windows/Linux specific error? Could you post the error messages that students are seeing? I have not heard of this issue before so I want to make sure what the issue is before I add it as a dependency. Also, I highly recommend that you have your students download the latest release (1.6.1 https://pypi.org/project/pysindy/). |
@loiseaujc any update on this? How goes your new class? |
Hi @akaptano Edit: Running on Windows 10. |
@briandesilva Any idea about this? qdldl is not in the requirements.txt file, but it is installed on my computers, so my guess is that qdldl gets installed when you install some of the other requirements. Why is isn't being installed automatically on Windows machines is not clear. Maybe adding cmake as a dependency is the easiest solution. |
I found a similar cmake issue on my desktop Mac computer, so I added it to the requirements. |
The one-hot basin encoding used a single tensor (i.e., a single location in memory) for all encodings. Hence, when a minibatch was created and __getitem__ was called several times, the one-hot encoding of the previous __getitem__ call would be overwritten by the encoding of the current call. Now, we create a new tensor in each __getitem__ to avoid this problem.
Fix readthedocs issues
Hej,
Some of my students have started to use pysindy for my dynamical system class and encounter an issue while installing the code from pip. CMake is needed to compile one of the deps.
At least, we should mention this in the README. Ideally, it should be explicitly added as a dependency in the pip stuff but I have no idea how to do so.
++
The text was updated successfully, but these errors were encountered: