Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/Makefile LIBS path assignment under Debian 9 and Fedora 30 #59

Open
adam-burns opened this issue Jun 25, 2019 · 0 comments
Open

src/Makefile LIBS path assignment under Debian 9 and Fedora 30 #59

adam-burns opened this issue Jun 25, 2019 · 0 comments

Comments

@adam-burns
Copy link
Member

When running make in the top directory in Fedora 30

make

Unlike Debian 9, the compile environment under Fedora 30 is not forgiving enough to allow the top Makefile to build source with

sources:
        THREADS=${THREADS} make -C src

with src/Makefile LIBS defined with path prefix beginning with src/ as well.

Removal of src/ $LIB path prefix still allows sucessful compilation under Debian 9(!) but also stops Fedora 30 from burping with

gcc -Wall -fPIE -fPIC -pie -O3 -I. -Iredis/deps/hiredis -Iredis/deps/jemalloc -o modprobe modprobe.o kmod_log.o -L src/redis/deps/hiredis -l:libhiredis.a -Llibdowse -l:libdowse.a -lkmod
/usr/bin/ld: cannot find -l:libhiredis.a
collect2: error: ld returned 1 exit status

This patch allows compilation under both OS environments:

$ git diff src/Makefile 
diff --git a/src/Makefile b/src/Makefile
index 0ea199f..d05711c 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -4,7 +4,7 @@ THREADS ?= 1
 
 CC = gcc
 CFLAGS = -Wall -fPIE -fPIC -pie -O3 -I. -Iredis/deps/hiredis -Iredis/deps/jemalloc
-LIBS = -L src/redis/deps/hiredis -l:libhiredis.a -Llibdowse -l:libdowse.a
+LIBS = -L redis/deps/hiredis -l:libhiredis.a -Llibdowse -l:libdowse.a
 
 all: base springs
        ./import.sh nmap-macs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant