Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running the dev script should open the demo app #11

Open
tarushnagpal opened this issue Oct 1, 2023 · 3 comments · May be fixed by #16
Open

Running the dev script should open the demo app #11

tarushnagpal opened this issue Oct 1, 2023 · 3 comments · May be fixed by #16
Assignees
@LemonDrop847
Labels
good first issue Good for newcomers hacktoberfest

Comments

@tarushnagpal
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently when you run a npm run dev, it opens a vite server with the index.html file which is related to how the dyte-sdk used to use it

Describe the solution you'd like
npm run dev should actually be running the react app placed in the examples folder, this is already built and looks like this
@tarushnagpal tarushnagpal changed the title Running the dev script should run the demo app Running the dev script should open the demo app Oct 1, 2023
@LemonDrop847
Copy link

Hey! can I be assigned to this?

@palashgo
Copy link
Contributor

palashgo commented Oct 2, 2023

Done @LemonDrop847

@LemonDrop847 LemonDrop847 linked a pull request Oct 2, 2023 that will close this issue
Open
@LemonDrop847
Copy link

Added a PR, please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LemonDrop847 LemonDrop847

Labels
good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: dev script now runs the project in \examples LemonDrop847/device-emulator
3 participants
@tarushnagpal @palashgo @LemonDrop847