Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: update ARIA attributes #587

Closed
ianmcburnie opened this issue Mar 13, 2019 · 0 comments
Closed

Dialog: update ARIA attributes #587

ianmcburnie opened this issue Mar 13, 2019 · 0 comments
Assignees
@ianmcburnie
Labels
aspect: a11y component: lightbox-dialog fellowship: good first issue A task that will take a day or more with minimal supervision status: merged
Milestone
5.0.0

Comments

@ianmcburnie
Copy link
Contributor

ianmcburnie commented Mar 13, 2019 •
edited
Loading

We should add aria-modal="true" attribute. We can also drop the role="document".
@ianmcburnie ianmcburnie self-assigned this Mar 27, 2019
@ianmcburnie ianmcburnie added the fellowship: good first issue A task that will take a day or more with minimal supervision label Apr 12, 2019
@ianmcburnie ianmcburnie removed their assignment May 1, 2019
@ianmcburnie ianmcburnie added this to the v2.9.0 milestone Jun 5, 2019
@ianmcburnie ianmcburnie self-assigned this Jun 5, 2019
@ianmcburnie ianmcburnie modified the milestones: v2.9.0, v3.0.0 Jun 26, 2019
@ianmcburnie ianmcburnie removed this from the v3.0.0 milestone Jul 16, 2019
@ianmcburnie ianmcburnie added this to the 5.0.0 milestone Jan 4, 2020
@ianmcburnie ianmcburnie changed the title Dialog: add aria-modal attribute Dialog: update ARIA attributes Jan 13, 2020
ianmcburnie added a commit that referenced this issue Jan 13, 2020
@ianmcburnie
Dialog: update ARIA attributes #587
1828115
@ianmcburnie ianmcburnie mentioned this issue Jan 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianmcburnie ianmcburnie

Labels
aspect: a11y component: lightbox-dialog fellowship: good first issue A task that will take a day or more with minimal supervision status: merged
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@ianmcburnie