From 9c401c98a3a07bafc98436e748a8b632fa0a5b2a Mon Sep 17 00:00:00 2001 From: Mario Dominguez Date: Wed, 11 Sep 2024 14:37:55 +0200 Subject: [PATCH 1/7] Refs #21538: Feature Signed-off-by: Mario Dominguez --- src/cpp/fastdds/publisher/DataWriterImpl.cpp | 3 +-- src/cpp/fastdds/subscriber/DataReaderImpl.cpp | 3 +-- src/cpp/fastdds/topic/TopicImpl.cpp | 3 +-- src/cpp/rtps/participant/RTPSParticipantImpl.cpp | 7 +++++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/cpp/fastdds/publisher/DataWriterImpl.cpp b/src/cpp/fastdds/publisher/DataWriterImpl.cpp index 623490a6d4e..01b3ea2d84d 100644 --- a/src/cpp/fastdds/publisher/DataWriterImpl.cpp +++ b/src/cpp/fastdds/publisher/DataWriterImpl.cpp @@ -1942,8 +1942,7 @@ ReturnCode_t DataWriterImpl::check_qos( { if (qos.durability().kind == PERSISTENT_DURABILITY_QOS) { - EPROSIMA_LOG_ERROR(RTPS_QOS_CHECK, "PERSISTENT Durability not supported"); - return RETCODE_UNSUPPORTED; + EPROSIMA_LOG_WARNING(RTPS_QOS_CHECK, "PERSISTENT Durability not supported, behaving as TRANSIENT instead"); } if (qos.destination_order().kind == BY_SOURCE_TIMESTAMP_DESTINATIONORDER_QOS) { diff --git a/src/cpp/fastdds/subscriber/DataReaderImpl.cpp b/src/cpp/fastdds/subscriber/DataReaderImpl.cpp index ea016650005..eb91da13950 100644 --- a/src/cpp/fastdds/subscriber/DataReaderImpl.cpp +++ b/src/cpp/fastdds/subscriber/DataReaderImpl.cpp @@ -1499,8 +1499,7 @@ ReturnCode_t DataReaderImpl::check_qos( { if (qos.durability().kind == PERSISTENT_DURABILITY_QOS) { - EPROSIMA_LOG_ERROR(DDS_QOS_CHECK, "PERSISTENT Durability not supported"); - return RETCODE_UNSUPPORTED; + EPROSIMA_LOG_WARNING(RTPS_QOS_CHECK, "PERSISTENT Durability not supported, behaving as TRANSIENT instead"); } if (qos.destination_order().kind == BY_SOURCE_TIMESTAMP_DESTINATIONORDER_QOS) { diff --git a/src/cpp/fastdds/topic/TopicImpl.cpp b/src/cpp/fastdds/topic/TopicImpl.cpp index 885440ee5ed..aa26407a81d 100644 --- a/src/cpp/fastdds/topic/TopicImpl.cpp +++ b/src/cpp/fastdds/topic/TopicImpl.cpp @@ -68,8 +68,7 @@ ReturnCode_t TopicImpl::check_qos( { if (PERSISTENT_DURABILITY_QOS == qos.durability().kind) { - EPROSIMA_LOG_ERROR(DDS_QOS_CHECK, "PERSISTENT Durability not supported"); - return RETCODE_UNSUPPORTED; + EPROSIMA_LOG_WARNING(RTPS_QOS_CHECK, "PERSISTENT Durability not supported, behaving as TRANSIENT instead"); } if (BY_SOURCE_TIMESTAMP_DESTINATIONORDER_QOS == qos.destination_order().kind) { diff --git a/src/cpp/rtps/participant/RTPSParticipantImpl.cpp b/src/cpp/rtps/participant/RTPSParticipantImpl.cpp index 47e6ad5ffe1..e617a64e674 100644 --- a/src/cpp/rtps/participant/RTPSParticipantImpl.cpp +++ b/src/cpp/rtps/participant/RTPSParticipantImpl.cpp @@ -2456,8 +2456,11 @@ bool RTPSParticipantImpl::get_persistence_service( { if (param.persistence_guid == c_Guid_Unknown) { - EPROSIMA_LOG_ERROR(RTPS_PARTICIPANT, "Cannot create persistence service. Persistence GUID not specified"); - return false; + EPROSIMA_LOG_WARNING(RTPS_PARTICIPANT, + "Persistence GUID not specified. Behaving as TRANSIENT_LOCAL"); + auto modified_durability_attrs = const_cast(param); + modified_durability_attrs.durabilityKind = TRANSIENT_LOCAL; + return true; } service = get_persistence_service(param); if (service == nullptr) From e2c0e86dbb878c094b9a53801c622532a9872ac2 Mon Sep 17 00:00:00 2001 From: Mario Dominguez Date: Wed, 11 Sep 2024 14:42:21 +0200 Subject: [PATCH 2/7] Refs #21538: Refactor make_persistent() and make_transient() in PubSub test API to make it clearer Signed-off-by: Mario Dominguez --- test/blackbox/api/dds-pim/PubSubReader.hpp | 21 ++++++++++++++++--- test/blackbox/api/dds-pim/PubSubWriter.hpp | 21 ++++++++++++++++--- .../common/DDSBlackboxTestsListeners.cpp | 8 +++---- .../common/RTPSBlackboxTestsPersistence.cpp | 16 +++++++------- ...lackboxTestsPersistenceNonIntraprocess.cpp | 6 +++--- .../common/RTPSWithRegistrationReader.hpp | 17 ++++++++++++++- .../common/RTPSWithRegistrationWriter.hpp | 15 +++++++++++++ 7 files changed, 82 insertions(+), 22 deletions(-) diff --git a/test/blackbox/api/dds-pim/PubSubReader.hpp b/test/blackbox/api/dds-pim/PubSubReader.hpp index 247dda1f5ff..b2257d83250 100644 --- a/test/blackbox/api/dds-pim/PubSubReader.hpp +++ b/test/blackbox/api/dds-pim/PubSubReader.hpp @@ -1631,16 +1631,31 @@ class PubSubReader } #if HAVE_SQLITE3 + PubSubReader& make_transient( + const std::string& filename, + const std::string& persistence_guid) + { + add_persitence_properties(filename, persistence_guid); + durability_kind(eprosima::fastdds::dds::TRANSIENT_DURABILITY_QOS); + return *this; + } + PubSubReader& make_persistent( const std::string& filename, const std::string& persistence_guid) + { + add_persitence_properties(filename, persistence_guid); + durability_kind(eprosima::fastdds::dds::PERSISTENT_DURABILITY_QOS); + return *this; + } + + void add_persitence_properties( + const std::string& filename, + const std::string& persistence_guid) { participant_qos_.properties().properties().emplace_back("dds.persistence.plugin", "builtin.SQLITE3"); participant_qos_.properties().properties().emplace_back("dds.persistence.sqlite3.filename", filename); - datareader_qos_.durability().kind = eprosima::fastdds::dds::TRANSIENT_DURABILITY_QOS; datareader_qos_.properties().properties().emplace_back("dds.persistence.guid", persistence_guid); - - return *this; } #endif // if HAVE_SQLITE3 diff --git a/test/blackbox/api/dds-pim/PubSubWriter.hpp b/test/blackbox/api/dds-pim/PubSubWriter.hpp index e39b2cd70a0..3dbe22f59b3 100644 --- a/test/blackbox/api/dds-pim/PubSubWriter.hpp +++ b/test/blackbox/api/dds-pim/PubSubWriter.hpp @@ -1708,16 +1708,31 @@ class PubSubWriter } #if HAVE_SQLITE3 + PubSubWriter& make_transient( + const std::string& filename, + const std::string& persistence_guid) + { + add_persitence_properties(filename, persistence_guid); + durability_kind(eprosima::fastdds::dds::TRANSIENT_DURABILITY_QOS); + return *this; + } + PubSubWriter& make_persistent( const std::string& filename, const std::string& persistence_guid) + { + add_persitence_properties(filename, persistence_guid); + durability_kind(eprosima::fastdds::dds::PERSISTENT_DURABILITY_QOS); + return *this; + } + + void add_persitence_properties( + const std::string& filename, + const std::string& persistence_guid) { participant_qos_.properties().properties().emplace_back("dds.persistence.plugin", "builtin.SQLITE3"); participant_qos_.properties().properties().emplace_back("dds.persistence.sqlite3.filename", filename); - datawriter_qos_.durability().kind = eprosima::fastdds::dds::TRANSIENT_DURABILITY_QOS; datawriter_qos_.properties().properties().emplace_back("dds.persistence.guid", persistence_guid); - - return *this; } #endif // if HAVE_SQLITE3 diff --git a/test/blackbox/common/DDSBlackboxTestsListeners.cpp b/test/blackbox/common/DDSBlackboxTestsListeners.cpp index 83f13b811c2..5d8892e55c2 100644 --- a/test/blackbox/common/DDSBlackboxTestsListeners.cpp +++ b/test/blackbox/common/DDSBlackboxTestsListeners.cpp @@ -1246,9 +1246,9 @@ TEST(DDSStatus, sample_lost_re_dw_re_persistence_dr) PubSubWriter writer(TEST_TOPIC_NAME); writer.reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) - .make_persistent(db_file_name, "67.62.79.64.75.62.5f.60.75.72.73.5f|76.65.79.74"); + .make_transient(db_file_name, "67.62.79.64.75.62.5f.60.75.72.73.5f|76.65.79.74"); reader.reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) - .make_persistent(db_file_name, "67.62.79.64.75.62.5f.60.75.72.73.5f|76.65.79.72"); + .make_transient(db_file_name, "67.62.79.64.75.62.5f.60.75.72.73.5f|76.65.79.72"); std::mutex test_step_mtx; @@ -1651,9 +1651,9 @@ TEST(DDSStatus, sample_lost_waitset_re_dw_re_persistence_dr) PubSubWriter writer(TEST_TOPIC_NAME); writer.reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) - .make_persistent(db_file_name, "67.62.79.64.75.62.5f.60.75.72.73.5f|76.65.79.74"); + .make_transient(db_file_name, "67.62.79.64.75.62.5f.60.75.72.73.5f|76.65.79.74"); reader.reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) - .make_persistent(db_file_name, "67.62.79.64.75.62.5f.60.75.72.73.5f|76.65.79.72"); + .make_transient(db_file_name, "67.62.79.64.75.62.5f.60.75.72.73.5f|76.65.79.72"); std::mutex test_step_mtx; std::condition_variable test_step_cv; diff --git a/test/blackbox/common/RTPSBlackboxTestsPersistence.cpp b/test/blackbox/common/RTPSBlackboxTestsPersistence.cpp index 33b05007505..29c9469c647 100644 --- a/test/blackbox/common/RTPSBlackboxTestsPersistence.cpp +++ b/test/blackbox/common/RTPSBlackboxTestsPersistence.cpp @@ -184,11 +184,11 @@ TEST_P(Persistence, RTPSAsNonReliableWithPersistence) RTPSWithRegistrationWriter writer(TEST_TOPIC_NAME); std::string ip("239.255.1.4"); - reader.make_persistent(db_file_name(), guid_prefix()).add_to_multicast_locator_list(ip, global_port).init(); + reader.make_transient(db_file_name(), guid_prefix()).add_to_multicast_locator_list(ip, global_port).init(); ASSERT_TRUE(reader.isInitialized()); - writer.make_persistent(db_file_name(), guid_prefix()).reliability(ReliabilityKind_t::BEST_EFFORT).init(); + writer.make_transient(db_file_name(), guid_prefix()).reliability(ReliabilityKind_t::BEST_EFFORT).init(); ASSERT_TRUE(writer.isInitialized()); @@ -215,11 +215,11 @@ TEST_P(Persistence, AsyncRTPSAsNonReliableWithPersistence) RTPSWithRegistrationWriter writer(TEST_TOPIC_NAME); std::string ip("239.255.1.4"); - reader.make_persistent(db_file_name(), guid_prefix()).add_to_multicast_locator_list(ip, global_port).init(); + reader.make_transient(db_file_name(), guid_prefix()).add_to_multicast_locator_list(ip, global_port).init(); ASSERT_TRUE(reader.isInitialized()); - writer.make_persistent(db_file_name(), guid_prefix()).reliability(ReliabilityKind_t::BEST_EFFORT). + writer.make_transient(db_file_name(), guid_prefix()).reliability(ReliabilityKind_t::BEST_EFFORT). asynchronously(RTPSWriterPublishMode::ASYNCHRONOUS_WRITER).init(); ASSERT_TRUE(writer.isInitialized()); @@ -247,12 +247,12 @@ TEST_P(Persistence, RTPSAsReliableWithPersistence) RTPSWithRegistrationWriter writer(TEST_TOPIC_NAME); std::string ip("239.255.1.4"); - reader.make_persistent(db_file_name(), guid_prefix()).add_to_multicast_locator_list(ip, global_port). + reader.make_transient(db_file_name(), guid_prefix()).add_to_multicast_locator_list(ip, global_port). reliability(ReliabilityKind_t::RELIABLE).init(); ASSERT_TRUE(reader.isInitialized()); - writer.make_persistent(db_file_name(), guid_prefix()).init(); + writer.make_transient(db_file_name(), guid_prefix()).init(); ASSERT_TRUE(writer.isInitialized()); @@ -279,12 +279,12 @@ TEST_P(Persistence, AsyncRTPSAsReliableWithPersistence) RTPSWithRegistrationWriter writer(TEST_TOPIC_NAME); std::string ip("239.255.1.4"); - reader.make_persistent(db_file_name(), guid_prefix()).add_to_multicast_locator_list(ip, global_port). + reader.make_transient(db_file_name(), guid_prefix()).add_to_multicast_locator_list(ip, global_port). reliability(ReliabilityKind_t::RELIABLE).init(); ASSERT_TRUE(reader.isInitialized()); - writer.make_persistent(db_file_name(), guid_prefix()).history_depth(10). + writer.make_transient(db_file_name(), guid_prefix()).history_depth(10). asynchronously(RTPSWriterPublishMode::ASYNCHRONOUS_WRITER).init(); ASSERT_TRUE(writer.isInitialized()); diff --git a/test/blackbox/common/RTPSBlackboxTestsPersistenceNonIntraprocess.cpp b/test/blackbox/common/RTPSBlackboxTestsPersistenceNonIntraprocess.cpp index 39c0331ed12..fb64990f321 100644 --- a/test/blackbox/common/RTPSBlackboxTestsPersistenceNonIntraprocess.cpp +++ b/test/blackbox/common/RTPSBlackboxTestsPersistenceNonIntraprocess.cpp @@ -78,7 +78,7 @@ class PersistenceNonIntraprocess : public ::testing::Test // Wait for undiscovery reader.wait_undiscovery(); - writer.make_persistent(db_file_name_writer(), guid_prefix()) + writer.make_transient(db_file_name_writer(), guid_prefix()) .reliability(ReliabilityKind_t::RELIABLE).init(); // Wait for discovery @@ -196,11 +196,11 @@ TEST_F(PersistenceNonIntraprocess, InconsistentAcknackReceived) RTPSWithRegistrationWriter writer(TEST_TOPIC_NAME); std::string ip("239.255.1.4"); - reader.make_persistent(db_file_name_reader(), guid_prefix()).add_to_multicast_locator_list(ip, global_port). + reader.make_transient(db_file_name_reader(), guid_prefix()).add_to_multicast_locator_list(ip, global_port). reliability(ReliabilityKind_t::RELIABLE).init(); EXPECT_TRUE(reader.isInitialized()); - writer.make_persistent(db_file_name_writer(), guid_prefix()). + writer.make_transient(db_file_name_writer(), guid_prefix()). reliability(ReliabilityKind_t::RELIABLE).init(); EXPECT_TRUE(writer.isInitialized()); diff --git a/test/blackbox/common/RTPSWithRegistrationReader.hpp b/test/blackbox/common/RTPSWithRegistrationReader.hpp index 931897accff..75e366b0745 100644 --- a/test/blackbox/common/RTPSWithRegistrationReader.hpp +++ b/test/blackbox/common/RTPSWithRegistrationReader.hpp @@ -530,6 +530,21 @@ class RTPSWithRegistrationReader } #if HAVE_SQLITE3 + RTPSWithRegistrationReader& make_transient( + const std::string& filename, + const eprosima::fastdds::rtps::GuidPrefix_t& guidPrefix) + { + reader_attr_.endpoint.persistence_guid.guidPrefix = guidPrefix; + reader_attr_.endpoint.persistence_guid.entityId = 0x55555555; + + std::cout << "Initializing transient READER " << reader_attr_.endpoint.persistence_guid << " with file " << + filename << std::endl; + + return durability(eprosima::fastdds::rtps::DurabilityKind_t::TRANSIENT) + .add_property("dds.persistence.plugin", "builtin.SQLITE3") + .add_property("dds.persistence.sqlite3.filename", filename); + } + RTPSWithRegistrationReader& make_persistent( const std::string& filename, const eprosima::fastdds::rtps::GuidPrefix_t& guidPrefix) @@ -540,7 +555,7 @@ class RTPSWithRegistrationReader std::cout << "Initializing persistent READER " << reader_attr_.endpoint.persistence_guid << " with file " << filename << std::endl; - return durability(eprosima::fastdds::rtps::DurabilityKind_t::TRANSIENT) + return durability(eprosima::fastdds::rtps::DurabilityKind_t::PERSISTENT) .add_property("dds.persistence.plugin", "builtin.SQLITE3") .add_property("dds.persistence.sqlite3.filename", filename); } diff --git a/test/blackbox/common/RTPSWithRegistrationWriter.hpp b/test/blackbox/common/RTPSWithRegistrationWriter.hpp index b535a7c0e45..7f8f6eded75 100644 --- a/test/blackbox/common/RTPSWithRegistrationWriter.hpp +++ b/test/blackbox/common/RTPSWithRegistrationWriter.hpp @@ -472,6 +472,21 @@ class RTPSWithRegistrationWriter } #if HAVE_SQLITE3 + RTPSWithRegistrationWriter& make_transient( + const std::string& filename, + const eprosima::fastdds::rtps::GuidPrefix_t& guidPrefix) + { + writer_attr_.endpoint.persistence_guid.guidPrefix = guidPrefix; + writer_attr_.endpoint.persistence_guid.entityId = 0xAAAAAAAA; + + std::cout << "Initializing transient WRITER " << writer_attr_.endpoint.persistence_guid + << " with file " << filename << std::endl; + + return durability(eprosima::fastdds::rtps::DurabilityKind_t::TRANSIENT) + .add_property("dds.persistence.plugin", "builtin.SQLITE3") + .add_property("dds.persistence.sqlite3.filename", filename); + } + RTPSWithRegistrationWriter& make_persistent( const std::string& filename, const eprosima::fastdds::rtps::GuidPrefix_t& guidPrefix) From bf026525f3f72950d5ecf87d1d58b87dd7ec5548 Mon Sep 17 00:00:00 2001 From: Mario Dominguez Date: Wed, 11 Sep 2024 14:42:48 +0200 Subject: [PATCH 3/7] Refs #21538: Fix unittests Signed-off-by: Mario Dominguez --- test/unittest/dds/participant/ParticipantTests.cpp | 9 +-------- test/unittest/dds/publisher/DataWriterTests.cpp | 9 ++++++--- test/unittest/dds/subscriber/DataReaderTests.cpp | 8 +++++--- 3 files changed, 12 insertions(+), 14 deletions(-) diff --git a/test/unittest/dds/participant/ParticipantTests.cpp b/test/unittest/dds/participant/ParticipantTests.cpp index 1a383e557f4..518332901a2 100644 --- a/test/unittest/dds/participant/ParticipantTests.cpp +++ b/test/unittest/dds/participant/ParticipantTests.cpp @@ -2157,7 +2157,7 @@ TEST(ParticipantTests, ChangeDefaultTopicQos) ASSERT_EQ(tqos.reliability().kind, BEST_EFFORT_RELIABILITY_QOS); qos.durability().kind = PERSISTENT_DURABILITY_QOS; - ASSERT_FALSE(participant->set_default_topic_qos(qos) == RETCODE_OK); + ASSERT_TRUE(participant->set_default_topic_qos(qos) == RETCODE_OK); ASSERT_TRUE(DomainParticipantFactory::get_instance()->delete_participant(participant) == RETCODE_OK); } @@ -2927,13 +2927,6 @@ TEST(ParticipantTests, CreateTopicNegativeClauses) topic = participant->create_topic("footopic", "fake_type_name", TOPIC_QOS_DEFAULT); ASSERT_EQ(topic, nullptr); - // Check that the topic is not created if a non supported durability QoS is provided - TopicQos tqos; - participant->get_default_topic_qos(tqos); - tqos.durability().kind = PERSISTENT_DURABILITY_QOS; - topic = participant->create_topic("footopic", type.get_type_name(), tqos); - ASSERT_EQ(topic, nullptr); - // Remove the participant ASSERT_EQ(DomainParticipantFactory::get_instance()->delete_participant(participant), RETCODE_OK); } diff --git a/test/unittest/dds/publisher/DataWriterTests.cpp b/test/unittest/dds/publisher/DataWriterTests.cpp index c3aa37ae846..6b21bc5dd72 100644 --- a/test/unittest/dds/publisher/DataWriterTests.cpp +++ b/test/unittest/dds/publisher/DataWriterTests.cpp @@ -650,9 +650,12 @@ TEST(DataWriterTests, InvalidQos) const ReturnCode_t unsupported_code = RETCODE_UNSUPPORTED; DataWriterQos qos; - qos = DATAWRITER_QOS_DEFAULT; - qos.durability().kind = PERSISTENT_DURABILITY_QOS; - EXPECT_EQ(unsupported_code, datawriter->set_qos(qos)); + + // qos = DATAWRITER_QOS_DEFAULT; + // qos.durability().kind = PERSISTENT_DURABILITY_QOS; + // Despite PERSISTENT_DURABILITY is not supported yet, + // DataWriter must behave as TRANSIENT + // EXPECT_EQ(unsupported_code, datawriter->set_qos(qos)); qos = DATAWRITER_QOS_DEFAULT; qos.destination_order().kind = BY_SOURCE_TIMESTAMP_DESTINATIONORDER_QOS; diff --git a/test/unittest/dds/subscriber/DataReaderTests.cpp b/test/unittest/dds/subscriber/DataReaderTests.cpp index 28316a86d4c..141e793ba6d 100644 --- a/test/unittest/dds/subscriber/DataReaderTests.cpp +++ b/test/unittest/dds/subscriber/DataReaderTests.cpp @@ -683,9 +683,11 @@ TEST_F(DataReaderTests, InvalidQos) /* Unsupported QoS */ const ReturnCode_t unsupported_code = RETCODE_UNSUPPORTED; - qos = DATAREADER_QOS_DEFAULT; - qos.durability().kind = PERSISTENT_DURABILITY_QOS; - EXPECT_EQ(unsupported_code, data_reader_->set_qos(qos)); + // qos = DATAREADER_QOS_DEFAULT; + // qos.durability().kind = PERSISTENT_DURABILITY_QOS; + // Despite PERSISTENT_DURABILITY is not supported yet, + // DataReader must behave as TRANSIENT + // EXPECT_EQ(unsupported_code, data_reader_->set_qos(qos)); qos = DATAREADER_QOS_DEFAULT; qos.destination_order().kind = BY_SOURCE_TIMESTAMP_DESTINATIONORDER_QOS; From c9259c4bbaae97be1d19a23451d7af5b303daba0 Mon Sep 17 00:00:00 2001 From: Mario Dominguez Date: Wed, 11 Sep 2024 14:43:16 +0200 Subject: [PATCH 4/7] Refs #21538: Add BB tests and refactor DDSPersistence test suite Signed-off-by: Mario Dominguez --- .../common/DDSBlackboxTestsPersistence.cpp | 127 +++++++++++++++--- 1 file changed, 110 insertions(+), 17 deletions(-) diff --git a/test/blackbox/common/DDSBlackboxTestsPersistence.cpp b/test/blackbox/common/DDSBlackboxTestsPersistence.cpp index 0c494407baf..9e479cf5ce7 100644 --- a/test/blackbox/common/DDSBlackboxTestsPersistence.cpp +++ b/test/blackbox/common/DDSBlackboxTestsPersistence.cpp @@ -35,7 +35,7 @@ enum communication_type DATASHARING }; -class PersistenceLargeData : public testing::TestWithParam +class DDSPersistenceTests : public testing::TestWithParam { public: @@ -113,7 +113,7 @@ class PersistenceLargeData : public testing::TestWithParam .history_kind(eprosima::fastdds::dds::KEEP_ALL_HISTORY_QOS) .resource_limits_max_samples(100) .reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) - .make_persistent(db_file_name(), "77.72.69.74.65.72.5f.70.65.72.73.5f|67.75.69.64") + .make_transient(db_file_name(), "77.72.69.74.65.72.5f.70.65.72.73.5f|67.75.69.64") .disable_builtin_transport() .add_user_transport_to_pparams(testTransport) .init(); @@ -160,17 +160,17 @@ class PersistenceLargeData : public testing::TestWithParam }; -TEST_P(PersistenceLargeData, PubSubAsReliablePubPersistentWithFrag) +TEST_P(DDSPersistenceTests, PubSubAsReliablePubTransientWithFrag) { fragment_data(true); } -TEST_P(PersistenceLargeData, PubSubAsReliablePubPersistentNoFrag) +TEST_P(DDSPersistenceTests, PubSubAsReliablePubTransientNoFrag) { fragment_data(false); } -TEST_P(PersistenceLargeData, PubSubAsReliablePubPersistentWithLifespanBefore) +TEST_P(DDSPersistenceTests, PubSubAsReliablePubTransientWithLifespanBefore) { PubSubWriter writer(TEST_TOPIC_NAME); PubSubReader reader(TEST_TOPIC_NAME); @@ -179,7 +179,7 @@ TEST_P(PersistenceLargeData, PubSubAsReliablePubPersistentWithLifespanBefore) .history_kind(eprosima::fastdds::dds::KEEP_ALL_HISTORY_QOS) .resource_limits_max_samples(100) .reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) - .make_persistent(db_file_name(), "77.72.69.74.65.72.5f.70.65.72.73.5f|67.75.69.64") + .make_transient(db_file_name(), "77.72.69.74.65.72.5f.70.65.72.73.5f|67.75.69.64") .lifespan_period({1, 0}) .init(); @@ -221,7 +221,7 @@ TEST_P(PersistenceLargeData, PubSubAsReliablePubPersistentWithLifespanBefore) ASSERT_EQ(0u, reader.block_for_all(std::chrono::seconds(1))); } -TEST_P(PersistenceLargeData, PubSubAsReliablePubPersistentWithLifespanSendingBefore) +TEST_P(DDSPersistenceTests, PubSubAsReliablePubTransientWithLifespanSendingBefore) { PubSubWriter writer(TEST_TOPIC_NAME); PubSubReader reader(TEST_TOPIC_NAME); @@ -230,7 +230,7 @@ TEST_P(PersistenceLargeData, PubSubAsReliablePubPersistentWithLifespanSendingBef .history_kind(eprosima::fastdds::dds::KEEP_ALL_HISTORY_QOS) .resource_limits_max_samples(100) .reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) - .make_persistent(db_file_name(), "77.72.69.74.65.72.5f.70.65.72.73.5f|67.75.69.64") + .make_transient(db_file_name(), "77.72.69.74.65.72.5f.70.65.72.73.5f|67.75.69.64") .lifespan_period({0, 100}) .init(); @@ -280,7 +280,7 @@ TEST_P(PersistenceLargeData, PubSubAsReliablePubPersistentWithLifespanSendingBef ASSERT_EQ(0u, reader.block_for_all(std::chrono::seconds(1))); } -TEST_P(PersistenceLargeData, PubSubAsReliablePubPersistentWithLifespanAfter) +TEST_P(DDSPersistenceTests, PubSubAsReliablePubTransientWithLifespanAfter) { PubSubWriter writer(TEST_TOPIC_NAME); PubSubReader reader(TEST_TOPIC_NAME); @@ -289,7 +289,7 @@ TEST_P(PersistenceLargeData, PubSubAsReliablePubPersistentWithLifespanAfter) .history_kind(eprosima::fastdds::dds::KEEP_ALL_HISTORY_QOS) .resource_limits_max_samples(100) .reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) - .make_persistent(db_file_name(), "77.72.69.74.65.72.5f.70.65.72.73.5f|67.75.69.64") + .make_transient(db_file_name(), "77.72.69.74.65.72.5f.70.65.72.73.5f|67.75.69.64") .lifespan_period({1, 0}) .init(); @@ -332,7 +332,7 @@ TEST_P(PersistenceLargeData, PubSubAsReliablePubPersistentWithLifespanAfter) ASSERT_EQ(0u, reader.block_for_all(std::chrono::seconds(1))); } -TEST_P(PersistenceLargeData, PubSubAsReliablePubPersistentWithStaticDiscovery) +TEST_P(DDSPersistenceTests, PubSubAsReliablePubTransientWithStaticDiscovery) { char* value = nullptr; std::string TOPIC_RANDOM_NUMBER; @@ -398,7 +398,7 @@ TEST_P(PersistenceLargeData, PubSubAsReliablePubPersistentWithStaticDiscovery) writer .history_kind(eprosima::fastdds::dds::KEEP_ALL_HISTORY_QOS) .reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) - .make_persistent(db_file_name(), "78.73.69.74.65.72.5f.70.65.72.73.5f|67.75.69.1") + .make_transient(db_file_name(), "78.73.69.74.65.72.5f.70.65.72.73.5f|67.75.69.1") .static_discovery("file://PubSubWriterPersistence_static_disc.xml") .unicastLocatorList(WriterUnicastLocators) .multicastLocatorList(WriterMulticastLocators) @@ -426,7 +426,7 @@ TEST_P(PersistenceLargeData, PubSubAsReliablePubPersistentWithStaticDiscovery) .history_kind(eprosima::fastdds::dds::KEEP_LAST_HISTORY_QOS) .history_depth(10) .reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) - .make_persistent(db_file_name(), "78.73.69.74.65.72.5f.70.65.72.73.5f|67.75.69.3") + .make_transient(db_file_name(), "78.73.69.74.65.72.5f.70.65.72.73.5f|67.75.69.3") .static_discovery("file://PubSubReaderPersistence_static_disc.xml") .unicastLocatorList(ReaderUnicastLocators) .multicastLocatorList(ReaderMulticastLocators) @@ -453,7 +453,6 @@ TEST_P(PersistenceLargeData, PubSubAsReliablePubPersistentWithStaticDiscovery) // Wait expecting not receiving data. ASSERT_EQ(10u, reader.block_for_all(std::chrono::seconds(1))); - // Destroy the DataWriter writer.destroy(); reader.stopReception(); @@ -473,16 +472,110 @@ TEST_P(PersistenceLargeData, PubSubAsReliablePubPersistentWithStaticDiscovery) } +TEST_P(DDSPersistenceTests, PubSubAsReliablePubPersistentBehavesAsTransient) +{ + PubSubWriter writer(TEST_TOPIC_NAME); + PubSubReader reader(TEST_TOPIC_NAME); + + writer + .history_kind(eprosima::fastdds::dds::KEEP_ALL_HISTORY_QOS) + .resource_limits_max_samples(100) + .reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) + // A PERSISTENT writer with a persistence guid must behave as TRANSIENT + .make_persistent(db_file_name(), "77.72.69.74.65.72.5f.70.65.72.73.5f|67.75.69.64") + .init(); + + ASSERT_TRUE(writer.isInitialized()); + + auto data = default_helloworld_data_generator(); + auto received_data = data; + + // Send data + writer.send(data); + // All data should be sent + ASSERT_TRUE(data.empty()); + // Destroy the DataWriter + writer.destroy(); + + reader + .history_kind(eprosima::fastdds::dds::KEEP_LAST_HISTORY_QOS) + .history_depth(10) + .reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) + // A TRANSIENT reader with no persistence guid should behave as TRANSIENT_LOCAL + .durability_kind(eprosima::fastdds::dds::TRANSIENT_DURABILITY_QOS) + .init(); + + ASSERT_TRUE(reader.isInitialized()); + + // Load the transient DataWriter with the changes saved in the database + writer.init(); + + ASSERT_TRUE(writer.isInitialized()); + + // Wait for discovery. + writer.wait_discovery(); + reader.wait_discovery(); + + reader.startReception(received_data); + + // Wait expecting receiving all data. + reader.block_for_all(); +} + +TEST_P(DDSPersistenceTests, PubSubAsReliablePubTransientWithNoPersistenceGUIDBehavesAsTransientLocal) +{ + PubSubWriter writer(TEST_TOPIC_NAME); + PubSubReader reader(TEST_TOPIC_NAME); + + writer + .history_kind(eprosima::fastdds::dds::KEEP_ALL_HISTORY_QOS) + .resource_limits_max_samples(100) + .reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) + // A TRANSIENT writer with a persistence guid must behave as TRANSIENT_LOCAL + .durability_kind(eprosima::fastdds::dds::TRANSIENT_DURABILITY_QOS) + .init(); + + ASSERT_TRUE(writer.isInitialized()); + + auto data = default_helloworld_data_generator(); + auto received_data = data; + + // Send data + writer.send(data); + + // All data should be sent + ASSERT_TRUE(data.empty()); + + reader + .history_kind(eprosima::fastdds::dds::KEEP_LAST_HISTORY_QOS) + .history_depth(10) + .reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) + // A TRANSIENT reader with no persistence guid should behave as TRANSIENT_LOCAL + .durability_kind(eprosima::fastdds::dds::TRANSIENT_DURABILITY_QOS) + .init(); + + ASSERT_TRUE(reader.isInitialized()); + + // Wait for discovery. + writer.wait_discovery(); + reader.wait_discovery(); + + reader.startReception(received_data); + + // Wait expecting receiving all data. + reader.block_for_all(); +} + #ifdef INSTANTIATE_TEST_SUITE_P #define GTEST_INSTANTIATE_TEST_MACRO(x, y, z, w) INSTANTIATE_TEST_SUITE_P(x, y, z, w) #else #define GTEST_INSTANTIATE_TEST_MACRO(x, y, z, w) INSTANTIATE_TEST_CASE_P(x, y, z, w) #endif // ifdef INSTANTIATE_TEST_SUITE_P -GTEST_INSTANTIATE_TEST_MACRO(PersistenceLargeData, - PersistenceLargeData, +GTEST_INSTANTIATE_TEST_MACRO(DDSPersistenceTests, + DDSPersistenceTests, testing::Values(TRANSPORT, INTRAPROCESS, DATASHARING), - [](const testing::TestParamInfo& info) + [](const testing::TestParamInfo& info) { switch (info.param) { From 456a9768746f5add42f82078dcae6b34afb5c8cc Mon Sep 17 00:00:00 2001 From: Mario Dominguez Date: Wed, 11 Sep 2024 14:58:00 +0200 Subject: [PATCH 5/7] Refs #21538: Linter Signed-off-by: Mario Dominguez --- test/blackbox/common/DDSBlackboxTestsPersistence.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/blackbox/common/DDSBlackboxTestsPersistence.cpp b/test/blackbox/common/DDSBlackboxTestsPersistence.cpp index 9e479cf5ce7..5d39d6aaad3 100644 --- a/test/blackbox/common/DDSBlackboxTestsPersistence.cpp +++ b/test/blackbox/common/DDSBlackboxTestsPersistence.cpp @@ -481,7 +481,7 @@ TEST_P(DDSPersistenceTests, PubSubAsReliablePubPersistentBehavesAsTransient) .history_kind(eprosima::fastdds::dds::KEEP_ALL_HISTORY_QOS) .resource_limits_max_samples(100) .reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) - // A PERSISTENT writer with a persistence guid must behave as TRANSIENT + // A PERSISTENT writer with a persistence guid must behave as TRANSIENT .make_persistent(db_file_name(), "77.72.69.74.65.72.5f.70.65.72.73.5f|67.75.69.64") .init(); @@ -501,7 +501,7 @@ TEST_P(DDSPersistenceTests, PubSubAsReliablePubPersistentBehavesAsTransient) .history_kind(eprosima::fastdds::dds::KEEP_LAST_HISTORY_QOS) .history_depth(10) .reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) - // A TRANSIENT reader with no persistence guid should behave as TRANSIENT_LOCAL + // A TRANSIENT reader with no persistence guid should behave as TRANSIENT_LOCAL .durability_kind(eprosima::fastdds::dds::TRANSIENT_DURABILITY_QOS) .init(); @@ -531,7 +531,7 @@ TEST_P(DDSPersistenceTests, PubSubAsReliablePubTransientWithNoPersistenceGUIDBeh .history_kind(eprosima::fastdds::dds::KEEP_ALL_HISTORY_QOS) .resource_limits_max_samples(100) .reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) - // A TRANSIENT writer with a persistence guid must behave as TRANSIENT_LOCAL + // A TRANSIENT writer with a persistence guid must behave as TRANSIENT_LOCAL .durability_kind(eprosima::fastdds::dds::TRANSIENT_DURABILITY_QOS) .init(); @@ -550,7 +550,7 @@ TEST_P(DDSPersistenceTests, PubSubAsReliablePubTransientWithNoPersistenceGUIDBeh .history_kind(eprosima::fastdds::dds::KEEP_LAST_HISTORY_QOS) .history_depth(10) .reliability(eprosima::fastdds::dds::RELIABLE_RELIABILITY_QOS) - // A TRANSIENT reader with no persistence guid should behave as TRANSIENT_LOCAL + // A TRANSIENT reader with no persistence guid should behave as TRANSIENT_LOCAL .durability_kind(eprosima::fastdds::dds::TRANSIENT_DURABILITY_QOS) .init(); From 0d592d16b35a352192ab82d7e35ebb57732074fd Mon Sep 17 00:00:00 2001 From: Mario Dominguez Date: Thu, 12 Sep 2024 11:38:45 +0200 Subject: [PATCH 6/7] Refs #21538: versions.md Signed-off-by: Mario Dominguez --- versions.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/versions.md b/versions.md index d33da506f3d..97f7813ff05 100644 --- a/versions.md +++ b/versions.md @@ -1,7 +1,7 @@ Forthcoming ----------- - +* Allow `PERSISTENT_DURABILITY` behaving as `TRANSIENT_DURABILITY`. Fallback to `TRANSIENT_LOCAL_DURABILITY` if no persistence guid is set. Version v3.0.0 -------------- From 3be074c6e114082ac991c3c85db4f8a8e6d39501 Mon Sep 17 00:00:00 2001 From: Mario Dominguez Date: Mon, 23 Sep 2024 11:50:03 +0200 Subject: [PATCH 7/7] Refs #21538: Apply Miguel's rev Signed-off-by: Mario Dominguez --- src/cpp/fastdds/publisher/DataWriterImpl.cpp | 4 -- src/cpp/fastdds/subscriber/DataReaderImpl.cpp | 4 -- src/cpp/fastdds/topic/TopicImpl.cpp | 4 -- .../common/DDSBlackboxTestsPersistence.cpp | 20 ++++++++++ .../dds/participant/ParticipantTests.cpp | 29 ++++++++++++++- .../dds/publisher/DataWriterTests.cpp | 37 ++++++++++++++++--- .../dds/subscriber/DataReaderTests.cpp | 25 ++++++++++--- 7 files changed, 98 insertions(+), 25 deletions(-) diff --git a/src/cpp/fastdds/publisher/DataWriterImpl.cpp b/src/cpp/fastdds/publisher/DataWriterImpl.cpp index 01b3ea2d84d..f4d732ec723 100644 --- a/src/cpp/fastdds/publisher/DataWriterImpl.cpp +++ b/src/cpp/fastdds/publisher/DataWriterImpl.cpp @@ -1940,10 +1940,6 @@ ReturnCode_t DataWriterImpl::check_qos_including_resource_limits( ReturnCode_t DataWriterImpl::check_qos( const DataWriterQos& qos) { - if (qos.durability().kind == PERSISTENT_DURABILITY_QOS) - { - EPROSIMA_LOG_WARNING(RTPS_QOS_CHECK, "PERSISTENT Durability not supported, behaving as TRANSIENT instead"); - } if (qos.destination_order().kind == BY_SOURCE_TIMESTAMP_DESTINATIONORDER_QOS) { EPROSIMA_LOG_ERROR(RTPS_QOS_CHECK, "BY SOURCE TIMESTAMP DestinationOrder not supported"); diff --git a/src/cpp/fastdds/subscriber/DataReaderImpl.cpp b/src/cpp/fastdds/subscriber/DataReaderImpl.cpp index eb91da13950..2ea8a902e88 100644 --- a/src/cpp/fastdds/subscriber/DataReaderImpl.cpp +++ b/src/cpp/fastdds/subscriber/DataReaderImpl.cpp @@ -1497,10 +1497,6 @@ ReturnCode_t DataReaderImpl::check_qos_including_resource_limits( ReturnCode_t DataReaderImpl::check_qos( const DataReaderQos& qos) { - if (qos.durability().kind == PERSISTENT_DURABILITY_QOS) - { - EPROSIMA_LOG_WARNING(RTPS_QOS_CHECK, "PERSISTENT Durability not supported, behaving as TRANSIENT instead"); - } if (qos.destination_order().kind == BY_SOURCE_TIMESTAMP_DESTINATIONORDER_QOS) { EPROSIMA_LOG_ERROR(DDS_QOS_CHECK, "BY SOURCE TIMESTAMP DestinationOrder not supported"); diff --git a/src/cpp/fastdds/topic/TopicImpl.cpp b/src/cpp/fastdds/topic/TopicImpl.cpp index aa26407a81d..c858ce3bafc 100644 --- a/src/cpp/fastdds/topic/TopicImpl.cpp +++ b/src/cpp/fastdds/topic/TopicImpl.cpp @@ -66,10 +66,6 @@ ReturnCode_t TopicImpl::check_qos_including_resource_limits( ReturnCode_t TopicImpl::check_qos( const TopicQos& qos) { - if (PERSISTENT_DURABILITY_QOS == qos.durability().kind) - { - EPROSIMA_LOG_WARNING(RTPS_QOS_CHECK, "PERSISTENT Durability not supported, behaving as TRANSIENT instead"); - } if (BY_SOURCE_TIMESTAMP_DESTINATIONORDER_QOS == qos.destination_order().kind) { EPROSIMA_LOG_ERROR(DDS_QOS_CHECK, "BY SOURCE TIMESTAMP DestinationOrder not supported"); diff --git a/test/blackbox/common/DDSBlackboxTestsPersistence.cpp b/test/blackbox/common/DDSBlackboxTestsPersistence.cpp index 5d39d6aaad3..30d62ce42b1 100644 --- a/test/blackbox/common/DDSBlackboxTestsPersistence.cpp +++ b/test/blackbox/common/DDSBlackboxTestsPersistence.cpp @@ -564,6 +564,26 @@ TEST_P(DDSPersistenceTests, PubSubAsReliablePubTransientWithNoPersistenceGUIDBeh // Wait expecting receiving all data. reader.block_for_all(); + + // Recreate the DataWriter and DataReader + writer.destroy(); + reader.destroy(); + + writer.init(); + reader.init(); + + ASSERT_TRUE(writer.isInitialized()); + ASSERT_TRUE(reader.isInitialized()); + + // Reader should not receive any data + // as the writer is not transient + auto unreceived_data = default_helloworld_data_generator(); + + // Send data + reader.startReception(unreceived_data); + + // Wait expecting not receiving data. + ASSERT_EQ(reader.block_for_all(std::chrono::seconds(2)), 0u); } #ifdef INSTANTIATE_TEST_SUITE_P diff --git a/test/unittest/dds/participant/ParticipantTests.cpp b/test/unittest/dds/participant/ParticipantTests.cpp index 518332901a2..6d35d254852 100644 --- a/test/unittest/dds/participant/ParticipantTests.cpp +++ b/test/unittest/dds/participant/ParticipantTests.cpp @@ -2909,7 +2909,6 @@ TEST(ParticipantTests, GetParticipantNames) /* * This test checks that a topic is not created with a wrong settings. * 1. Check that the topic is not created if a wrong type name is provided. - * 2. Check that the topic is not created if a non supported durability QoS is provided. */ TEST(ParticipantTests, CreateTopicNegativeClauses) { @@ -2931,6 +2930,34 @@ TEST(ParticipantTests, CreateTopicNegativeClauses) ASSERT_EQ(DomainParticipantFactory::get_instance()->delete_participant(participant), RETCODE_OK); } +/* + * This test checks that a topic is created with a valid settings. + * 1. Check that the topic is created if a supported durability QoS is provided. + */ +TEST(ParticipantTests, CreateTopicPositiveClauses) +{ + // Create the participant + DomainParticipant* participant = + DomainParticipantFactory::get_instance()->create_participant( + (uint32_t)GET_PID() % 230, PARTICIPANT_QOS_DEFAULT); + + // Register the type + TypeSupport type(new TopicDataTypeMock()); + type.register_type(participant); + + // Check that the topic is created if a PERSITENT durability QoS is provided + TopicQos tqos; + Topic* topic; + participant->get_default_topic_qos(tqos); + tqos.durability().kind = PERSISTENT_DURABILITY_QOS; + topic = participant->create_topic("footopic", type.get_type_name(), tqos); + ASSERT_NE(topic, nullptr); + + // Cleanup + ASSERT_EQ(participant->delete_topic(topic), RETCODE_OK); + ASSERT_EQ(DomainParticipantFactory::get_instance()->delete_participant(participant), RETCODE_OK); +} + /* * This test checks the contais_entity() DomainParticipant member function. * 1. Check that the participant contains an already created topic in this participant. diff --git a/test/unittest/dds/publisher/DataWriterTests.cpp b/test/unittest/dds/publisher/DataWriterTests.cpp index 6b21bc5dd72..33a96c5ba53 100644 --- a/test/unittest/dds/publisher/DataWriterTests.cpp +++ b/test/unittest/dds/publisher/DataWriterTests.cpp @@ -651,12 +651,6 @@ TEST(DataWriterTests, InvalidQos) DataWriterQos qos; - // qos = DATAWRITER_QOS_DEFAULT; - // qos.durability().kind = PERSISTENT_DURABILITY_QOS; - // Despite PERSISTENT_DURABILITY is not supported yet, - // DataWriter must behave as TRANSIENT - // EXPECT_EQ(unsupported_code, datawriter->set_qos(qos)); - qos = DATAWRITER_QOS_DEFAULT; qos.destination_order().kind = BY_SOURCE_TIMESTAMP_DESTINATIONORDER_QOS; EXPECT_EQ(unsupported_code, datawriter->set_qos(qos)); @@ -717,6 +711,37 @@ TEST(DataWriterTests, InvalidQos) ASSERT_TRUE(DomainParticipantFactory::get_instance()->delete_participant(participant) == RETCODE_OK); } +TEST(DataWriterTests, PersistentDurabilityIsAValidQoS) +{ + DomainParticipantQos pqos = PARTICIPANT_QOS_DEFAULT; + pqos.entity_factory().autoenable_created_entities = false; + DomainParticipant* participant = DomainParticipantFactory::get_instance()->create_participant(0, pqos); + ASSERT_NE(participant, nullptr); + + Publisher* publisher = participant->create_publisher(PUBLISHER_QOS_DEFAULT); + ASSERT_NE(publisher, nullptr); + + TypeSupport type(new TopicDataTypeMock()); + type.register_type(participant); + + Topic* topic = participant->create_topic("footopic", type.get_type_name(), TOPIC_QOS_DEFAULT); + ASSERT_NE(topic, nullptr); + + DataWriter* datawriter = publisher->create_datawriter(topic, DATAWRITER_QOS_DEFAULT); + ASSERT_NE(datawriter, nullptr); + + DataWriterQos qos; + qos = DATAWRITER_QOS_DEFAULT; + qos.durability().kind = PERSISTENT_DURABILITY_QOS; + // PERSISTENT DataWriter behaves as TRANSIENT + EXPECT_EQ(RETCODE_OK, datawriter->set_qos(qos)); + + // Cleanup + ASSERT_TRUE(publisher->delete_datawriter(datawriter) == RETCODE_OK); + ASSERT_TRUE(participant->delete_topic(topic) == RETCODE_OK); + ASSERT_TRUE(participant->delete_publisher(publisher) == RETCODE_OK); +} + //TODO: Activate the test once PSM API for DataWriter is in place //TEST(DataWriterTests, DISABLED_ChangePSMDataWriterQos) //{ diff --git a/test/unittest/dds/subscriber/DataReaderTests.cpp b/test/unittest/dds/subscriber/DataReaderTests.cpp index 141e793ba6d..eca15be972c 100644 --- a/test/unittest/dds/subscriber/DataReaderTests.cpp +++ b/test/unittest/dds/subscriber/DataReaderTests.cpp @@ -683,12 +683,6 @@ TEST_F(DataReaderTests, InvalidQos) /* Unsupported QoS */ const ReturnCode_t unsupported_code = RETCODE_UNSUPPORTED; - // qos = DATAREADER_QOS_DEFAULT; - // qos.durability().kind = PERSISTENT_DURABILITY_QOS; - // Despite PERSISTENT_DURABILITY is not supported yet, - // DataReader must behave as TRANSIENT - // EXPECT_EQ(unsupported_code, data_reader_->set_qos(qos)); - qos = DATAREADER_QOS_DEFAULT; qos.destination_order().kind = BY_SOURCE_TIMESTAMP_DESTINATIONORDER_QOS; EXPECT_EQ(unsupported_code, data_reader_->set_qos(qos)); @@ -731,6 +725,10 @@ TEST_F(DataReaderTests, InvalidQos) /* Inmutable QoS */ const ReturnCode_t inmutable_code = RETCODE_IMMUTABLE_POLICY; + qos = DATAREADER_QOS_DEFAULT; + qos.durability().kind = PERSISTENT_DURABILITY_QOS; + EXPECT_EQ(inmutable_code, data_reader_->set_qos(qos)); + qos = DATAREADER_QOS_DEFAULT; qos.resource_limits().max_samples = 5000; qos.resource_limits().max_instances = 2; @@ -783,6 +781,21 @@ TEST_F(DataReaderTests, InvalidQos) EXPECT_EQ(inmutable_code, data_reader_->set_qos(qos)); } +TEST_F(DataReaderTests, PersistentDurabilityIsAValidQoS) +{ + DataReaderQos qos; + qos = DATAREADER_QOS_DEFAULT; + qos.durability().kind = PERSISTENT_DURABILITY_QOS; + + create_entities( + nullptr, + qos + ); + + // PERSISTENT DataReader behaves as TRANSIENT + EXPECT_NE(nullptr, data_reader_); +} + /** * This test checks all variants of read / take in several situations for a keyed plain type. */