You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is not a good pattern to have. @guillaumechauvat had mentioned this before.
logger.error(...)
return1
Rather than use C / Fortran style integer return, we should raise an error to avoid confusing error messages. This however might break some compatibility in user code, because someone might be not catching the errors as they should.
We can also have a PymechError custom exception if it helps.
The text was updated successfully, but these errors were encountered:
This is not a good pattern to have. @guillaumechauvat had mentioned this before.
Rather than use C / Fortran style integer return, we should raise an error to avoid confusing error messages. This however might break some compatibility in user code, because someone might be not catching the errors as they should.
We can also have a
PymechError
custom exception if it helps.The text was updated successfully, but these errors were encountered: