Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export more S3 methods for model_performance() generic #452

Closed
IndrajeetPatil opened this issue Jul 18, 2022 · 1 comment
Closed

Export more S3 methods for model_performance() generic #452

IndrajeetPatil opened this issue Jul 18, 2022 · 1 comment
Labels
Beginner-friendly 🤝 Friendly for new contributors Low priority 😴 This issue can be easily workaround or happens only in edge cases

Comments

@IndrajeetPatil
Copy link
Member

Same issue as easystats/parameters#746

broom_glance <- ls(getNamespace("broom"))
broom_glance <- broom_glance[grepl("^glance", broom_glance)]
broom_supported <- gsub("^glance.", "", broom_glance)
easystats_glance <- ls(getNamespace("performance"))
easystats_glance <- easystats_glance[grepl("^model_performance", easystats_glance)]
easystats_supported <- gsub("^model_performance.", "", easystats_glance)

broom_supported[!broom_supported %in% easystats_supported]
#>  [1] "aareg"            "anova"            "aov"              "biglm"           
#>  [5] "binDesign"        "cch"              "clmm"             "coeftest"        
#>  [9] "crr"              "cv.glmnet"        "data.frame"       "drc"             
#> [13] "durbinWatsonTest" "ergm"             "factanal"         "fitdistr"        
#> [17] "gam"              "Gam"              "garch"            "geeglm"          
#> [21] "glmnet"           "glmRob"           "gmm"              "htest"           
#> [25] "list"             "lmodel2"          "lmRob"            "Mclust"          
#> [29] "mfx"              "mjoint"           "muhaz"            "negbin"          
#> [33] "nlrq"             "nls"              "NULL"             "orcutt"          
#> [37] "pam"              "poLCA"            "pyears"           "ridgelm"         
#> [41] "rlm"              "rq"               "rqs"              "sarlm"           
#> [45] "Sarlm"            "smooth.spline"    "speedglm"         "speedlm"         
#> [49] "summary.lm"       "summaryDefault"   "survdiff"         "survexp"         
#> [53] "survfit"          "svyolr"           "tbl_df"           "varest"          
#> [57] "optim"

Created on 2022-07-18 by the reprex package (v2.0.1.9000)

@IndrajeetPatil IndrajeetPatil added Low priority 😴 This issue can be easily workaround or happens only in edge cases Beginner-friendly 🤝 Friendly for new contributors labels Jul 18, 2022
@IndrajeetPatil IndrajeetPatil linked a pull request Oct 21, 2022 that will close this issue
@strengejacke
Copy link
Member

I think we should close this for now, for the same reason as mentioned here:
easystats/parameters#807 (comment)

Unless someone is willing to (add) test for each single class where we additionally want to export a generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beginner-friendly 🤝 Friendly for new contributors Low priority 😴 This issue can be easily workaround or happens only in edge cases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants