Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modelling Tier 2 in HCA metadata schema #1279

Open
arschat opened this issue Jul 10, 2024 · 2 comments
Open

Modelling Tier 2 in HCA metadata schema #1279

arschat opened this issue Jul 10, 2024 · 2 comments
Labels
HCA operations This issue is an operational task

Comments

@arschat
Copy link
Collaborator

arschat commented Jul 10, 2024

In this ticket we will keep track of the discussions on how to model the Tier 2 fields across all bionetworks.

We have decided to model the Tier 2 fields in content specific modules rather than bionetwork modules.

For the lung bionetwork, we received a list of fields that are going to be part of their Tier 2 (mentioned in #1235). We've grouped them in 3 modules.

  • generic (not a separate module, included in the donor schema)
  • medical_tests
  • diseases_stages / diseases_characteristics

There is a PR for the addition of the medical_tests module in the donor level here. There is a $comment keyword added to specify that this is for lung bionetwork and that these fields describe the pulmonary_function_parameter.

@arschat arschat added the operations This issue is an operational task label Jul 10, 2024
@arschat arschat changed the title Modelling of Tier 2 fields in HCA metadata schema Modelling Tier 2 in HCA metadata schema Jul 10, 2024
@arschat
Copy link
Collaborator Author

arschat commented Jul 22, 2024

@arschat
Copy link
Collaborator Author

arschat commented Aug 14, 2024

After discussions with Amnon, the keyword $comment was replaced by the attribute bionetwork which allows an array of strings and conveys meaning compared to $comment. We dropped the pulmonary_function_parameter description in that attribute. bionetwork attribute is going to be filled only in non-generic fields.
lung medical tests PR is now merged.

Next PR is smoking related fields.

@idazucchi idazucchi added the HCA label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HCA operations This issue is an operational task
Projects
None yet
Development

No branches or pull requests

2 participants