Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common filter layout #27

Open
tschaka1904 opened this issue Mar 14, 2017 · 3 comments
Open

Common filter layout #27

tschaka1904 opened this issue Mar 14, 2017 · 3 comments

Comments

@tschaka1904
Copy link

In the Complex-Portal, as I think in many of the other EBI pages, we have a results page. There you can navigate through the results using the suggested pagination and filters.

screen shot 2017-03-14 at 16 29 45

Maybe, it would be worth to have a common layout and design for the filters?

@khawkins98
Copy link
Contributor

Yes, good candidate for a shared pattern.

Would also be nice to build in a responsive approach -- perhaps with the sub-categories being accordian-collpased on small mobile.

A couple of examples from around EBI:

I'm sure there are others, but I don't recall seeing on that seemed like a pattern that could easily be ported -- we might want to use the one you have as a base pattern. Is the page somewhere I can access, or just on your local machine?

@tschaka1904
Copy link
Author

tschaka1904 commented Mar 16, 2017

I like the UniProt one the most. Looks very clean.

Sure, here is the source code: https://github.com/Complex-Portal/complex-portal-view/blob/v0.0.4-beta/src/app/complex/complex-results/complex-filter/complex-filter.component.html

And here is the and visual example: https://complex-portal.github.io/complex-portal-view/search?query=GO%3A0016491

...slightly off topic, but the loading bar in EBI Search, which is just underneath the header. Is that foundation or something else?

@khawkins98
Copy link
Contributor

And here is Interpro in the new version:

image

http://wwwdev.ebi.ac.uk/interpro/sequencesearch/iprscan5-S20170316-145537-0616-23692636-hx

Thanks for the link to your dev version.

As for EBI Search, that's all done in Angular -- I believe it's a common Angular pattern. I think it's quite nice and could be "ported" to Foundation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants