Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that gain vectors are the correct size in the interpolator #47

Open
tomjnixon opened this issue Sep 26, 2022 · 0 comments
Open

check that gain vectors are the correct size in the interpolator #47

tomjnixon opened this issue Sep 26, 2022 · 0 comments

Comments

@tomjnixon
Copy link
Member

an assert in apply_interp that both points are the same size would catch an out-of-bounds read (or null pointer dereference) in some cases

it might be nice to do a more thorough check by passing in the expected size to GainInterpolator then checking them in process as they are used, but that's a bit more complex and an API change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant