Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mixed type elements #36

Open
brey opened this issue Feb 8, 2022 · 3 comments
Open

Support mixed type elements #36

brey opened this issue Feb 8, 2022 · 3 comments

Comments

@brey
Copy link
Collaborator

brey commented Feb 8, 2022

This functionality is already available in pyposeidon. We need to transfer it here.

brey added a commit to brey/Thalassa that referenced this issue Feb 15, 2022
Probably the structure needs to be revisited.
@wzhengui
Copy link
Collaborator

wzhengui commented Mar 3, 2022

Hi George: I already fixed this in my recent PR.

@pmav99
Copy link
Collaborator

pmav99 commented Mar 15, 2023

@brey do you mean visualizing quads? What we currently have is splitting quads in triangles. Is this good enough? If yes we should close. We can keep the ticket open to tackle this in the future though, too.

@brey
Copy link
Collaborator Author

brey commented Mar 15, 2023

Indeed the issue is with the visualisation of the quads. I have a solution using gv.Path but it's slow and create issues with the api. I suggest we leave it open and revisit if time permits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants