Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC changes for protocol Q (part 2) #3023

Open
dsawali opened this issue Aug 15, 2024 · 3 comments · May be fixed by #3040
Open

RPC changes for protocol Q (part 2) #3023

dsawali opened this issue Aug 15, 2024 · 3 comments · May be fixed by #3040
Assignees
@hui-an-yang
Labels
quebec rpc
Milestone
v21

Comments

@dsawali
Copy link
Contributor

dsawali commented Aug 15, 2024

In the 2 following paths ../ is short for /chains/<chain_id>/blocks/<block_id>/context/contracts/<contract_id>/

  • Added RPC GET ../spendable which is identical to GET ../balance
  • Added RPC GET ../spendable_and_frozen_bonds which is identical to GET ../balance_and_frozen_bonds
@dsawali dsawali changed the title [RPC] RPC changes for Quebec (part 2) [RPC] RPC changes for protocol Q (part 2) Aug 15, 2024
@dsawali dsawali changed the title [RPC] RPC changes for protocol Q (part 2) RPC changes for protocol Q (part 2) Aug 15, 2024
@dsawali dsawali added this to the v21 milestone Sep 5, 2024
@hui-an-yang
Copy link
Collaborator

hui-an-yang commented Sep 5, 2024 •
edited
Loading

Are we adding new endpoint in rpc accordingly?
like getSpendable and getSpendableAndFrozenBonds to our RpcClient?

hui-an-yang added a commit that referenced this issue Sep 9, 2024
@hui-an-yang
feat: add getSpendable rpc endpoint
1cd66b4 
re #3023
hui-an-yang added a commit that referenced this issue Sep 9, 2024
@hui-an-yang
feat: add getBalanceAndFrozenBonds and getSpendableAndFrozenBonds rpc…
750fe59 
… endpoint

re #3023
@hui-an-yang hui-an-yang linked a pull request Sep 9, 2024 that will close this issue
Open
9 tasks
@dsawali
Copy link
Contributor Author

dsawali commented Sep 9, 2024

in the beginning I thought it would be good to add them, but since we aren't really supporting the other endpoints for bakers, this change seems like it doesn't need to happen. I'll be closing it

@dsawali dsawali closed this as completed Sep 9, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Taquito Dev Sep 9, 2024
@hui-an-yang
Copy link
Collaborator

This one actually related to our user it's based of contracts/<contract_id>/ and we do support contracts/<contract_id>/balance seem to make sense to support contracts/<contract_id>/spendable
And
And a good idea to support ../spendable_and_frozen_bonds and ../balance_and_frozen_bonds too

@hui-an-yang hui-an-yang reopened this Sep 13, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in Taquito Dev Sep 13, 2024
@hui-an-yang hui-an-yang moved this from Review approved to Review in progress in Taquito Dev Sep 27, 2024
@hui-an-yang hui-an-yang self-assigned this Oct 2, 2024
@hui-an-yang hui-an-yang linked a pull request Oct 2, 2024 that will close this issue
Betanet0829 #3040
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hui-an-yang hui-an-yang

Labels
quebec rpc
Projects
Taquito Dev
Status: Review in progress
Milestone
v21
Development

Successfully merging a pull request may close this issue.

Betanet0829 ecadlabs/taquito
2 participants
@dsawali @hui-an-yang