Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RecurrenceExpander.getOccurrences() is including endDate in range #47

Open
nealeu opened this issue Oct 25, 2022 · 0 comments
Open

RecurrenceExpander.getOccurrences() is including endDate in range #47

nealeu opened this issue Oct 25, 2022 · 0 comments
Assignees
@nealeu
Labels
bug

Comments

@nealeu
Copy link
Contributor

nealeu commented Oct 25, 2022

If we have recurrences that start at midnight and are asking for recurrences on a given day, then endDate is startDate + 24 hours.

The specified interval is always a closed, open range, i.e. it should exclude the end of the range.

We are getting the occurrence that match the end of the range here.
@nealeu nealeu added the bug label Oct 25, 2022
@nealeu nealeu self-assigned this Oct 25, 2022
nealeu added a commit that referenced this issue Oct 25, 2022
@nealeu
#47 Clean up RecurrenceExpander.java
cf13d7d
nealeu added a commit that referenced this issue Oct 25, 2022
@nealeu
#47 Clean up InstanceList.java
f335276
nealeu added a commit that referenced this issue Oct 25, 2022
@nealeu
#47 Add test for midnight in RecurrenceExpanderTest
be6c1f2
nealeu added a commit that referenced this issue Oct 25, 2022
@nealeu
#47 Don't add recurrences to InstanceList if not strictly before rang…
966cd77 
…eEnd

To workaround ical4j/ical4j#603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nealeu nealeu

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nealeu