Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of VersionFourGenerator from commons-id with UUID.randomUUID() #54

Open
nealeu opened this issue Dec 28, 2023 · 0 comments
Open

Replace use of VersionFourGenerator from commons-id with UUID.randomUUID() #54

nealeu opened this issue Dec 28, 2023 · 0 comments

Comments

@nealeu
Copy link
Contributor

nealeu commented Dec 28, 2023

Because commons-id was abandoned moons ago, and randomUUID() generates a v4 UUID!
nealeu added a commit that referenced this issue Dec 28, 2023
@nealeu
#54 Replace VersionFourGenerator.nextIdentifier() with UUID.randomUUID()
49cc787 
It's been there and supported since Java 1.5, while commons-id is something we want to get rid of.
nealeu added a commit that referenced this issue Dec 28, 2023
@nealeu
#54 Replace injected VersionFourGenerator with UUID.randomUUID()
cc32b57 
This also cleans up empty init() and destroy() impls by making an empty default impl on the Dao interface.
nealeu added a commit that referenced this issue Dec 28, 2023
@nealeu
#54 Replace SessionIdGenerator with RandomStringUtils.randomGraph(15)
03acd89 
This is only used for ticket keys and random passwords, so while Commons ID impl attempted to avoid clashes by using some time elements, we have no concern here unless someone finds an issue as these features are also unused by ECCO and part of bits that could be removed (e.g. authentication).
nealeu added a commit that referenced this issue Dec 28, 2023
@nealeu
#54 Remove commons-id dependency
3839abc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nealeu