Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle log and report download errors in UI #1421

Open
mmurto opened this issue Nov 13, 2024 · 0 comments
Open

Handle log and report download errors in UI #1421

mmurto opened this issue Nov 13, 2024 · 0 comments
Labels
bug Something isn't working as expected. ui Issues related to the UI.

Comments

@mmurto
Copy link
Contributor

mmurto commented Nov 13, 2024

          > Looks like the UI is not handling the error correctly and writing the error response to the file. @mmurto Is it even possible to improve that with the way downloads are currently implemented or does this depend on #178?

Doesn't depend on it - this does not throw when the API returns an error code as the fetch succeeds, so it should be modified to throw and display an error in the UI if the response status in not 2xx.

Originally posted by @mmurto in #1415 (comment)

The same should be done for report downloads in addition to logs.

@mmurto mmurto added bug Something isn't working as expected. ui Issues related to the UI. labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected. ui Issues related to the UI.
Projects
None yet
Development

No branches or pull requests

1 participant