Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeavingAdaptor optimisations cause Equinox weaving problems #305

Closed
kriegaex opened this issue Apr 8, 2024 · 2 comments · Fixed by #304
Closed

WeavingAdaptor optimisations cause Equinox weaving problems #305

kriegaex opened this issue Apr 8, 2024 · 2 comments · Fixed by #304
Assignees
Labels
AJDT Eclipse AspectJ Development Tools bug Something isn't working
Milestone

Comments

@kriegaex
Copy link
Contributor

kriegaex commented Apr 8, 2024

A contribution by @urisimchoni for AspectJ 1.9.21.1 fixed problem #279, but introduced a new one downstream in Eclipse when using Equinox OSGi weaving via AJDT, see eclipse-aspectj/ajdt#57.

Part of the PR needs to be reverted so as to still keep the AspectJ fix intact while not messing up Equinox weaving.

@kriegaex kriegaex added bug Something isn't working AJDT Eclipse AspectJ Development Tools labels Apr 8, 2024
@kriegaex kriegaex added this to the 1.9.22.1 milestone Apr 8, 2024
@kriegaex kriegaex self-assigned this Apr 8, 2024
@urisimchoni
Copy link
Contributor

@kriegaex on first glance it appears like this revert doesn't break #279. I removed the generated class keys because I thought they were not needed, not because they somehow interfere with fixing #279. Do you agree?

@kriegaex
Copy link
Contributor Author

kriegaex commented Apr 8, 2024

@urisimchoni, it seems as if you are right. My test results in AspectJ and AJDT are looking good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AJDT Eclipse AspectJ Development Tools bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants