Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opened Traces selection unnecessarily opens traces in trace-server #278

Open
PatrickTasse opened this issue Feb 23, 2021 · 2 comments
Open

Comments

@PatrickTasse
Copy link
Contributor

With the latest changes, the 'Opened Traces' widget in the Trace Viewer view will show the list of every trace that has ever been opened in the trace server (using 'Open With > Trace Viewer' menu in Explorer or 'Open Trace' dialog in Trace Viewer) and that has not been deleted. When a trace tab is closed, the trace remains opened in the trace-server and still appears in the 'Opened Traces' widget. But after a trace-server restart, the trace may be closed in the trace-server and it will still appear in the client.

Whenever the selection changes in the 'Opened Traces' widget, the list of available analyses for this trace is fetched from the trace-server. If the trace is closed in the trace-server, it will be opened automatically to be able to respond to the request.

This means that, even if all the trace tabs are closed in the client, navigating up and down in the 'Opened Traces' list will create trace instances in the trace-server and use up memory resources.

It is possible for the client to know that the trace is closed in the trace-server by examining the 'indexingStatus' in the Experiment model (RUNNING/COMPLETED/CLOSED). But note that following a trace-server restart, the status could be CLOSED even if the trace tab is still opened. Maybe the available analyses should still be fetched in this case.

After closing a trace tab, the trace could still be opened in the trace-server and this will be indicated in the Experiment model. Should the 'Available Analyses' widget still be filled in this case? Or should it be filled only when the trace tab is opened?

@bhufmann
Copy link
Collaborator

After closing a trace tab, the trace could still be opened in the trace-server and this will be indicated in the Experiment model. Should the 'Available Analyses' widget still be filled in this case? Or should it be filled only when the trace tab is opened?
This is not an issue anymore. The current behavior is that the list of "Available views" is cleared when no trace tab is open.

@PatrickTasse do you want to close this ticket?

You could close this one and spawn a new ticket about freeing trace resource on the server when the trace tab is closed. Either by command or the server could free the resources if not used for a long time automatically and re-open the trace if queried again.

@bhufmann
Copy link
Collaborator

bhufmann commented Nov 3, 2023

Will it be fixed by #1033?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants