[#455] If constructor arguments fail to resolve, propagate failure #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davmac314
force-pushed
the
fix-bug-gh-455
branch
from
ec7a143
to
b436083
Compare
davmac314
changed the title
|
Latest push corrects the issue number in commit comment, no code change from previous. |
|
Thanks for the PR - for now I make the same comment as #448 (comment) |
davmac314
force-pushed
the
fix-bug-gh-455
branch
from
b436083
to
72cced5
Compare
|
Rebased on current main. |
… failure This change prevents invalid partial specialisations from being chosen when instantiating a template in cases where the expression for the type/value of a template parameter involves a constructor call.
davmac314
force-pushed
the
fix-bug-gh-455
branch
from
72cced5
to
4ec1115
Compare
|
This change looks good and functions as advertised. |
|
@jonahgraham Could this be merged? |
jonahgraham
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
At recent CDT calls we discussed how to handle reviews where there is insufficient expertise to review amongst existing committers and decided to accept such changes that look reasonable and appear sufficiently tested.
|
Thank you @davmac314 for this improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents invalid partial specialisations from being chosen when
instantiating a template in cases where the expression for the type/value of a template parameter involves a constructor call.
A test is included.