[#457] Fix partial specialisation matching for deduced primitive types #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR - for now I make the same comment as #448 (comment) |
davmac314
force-pushed
the
fix-gh-457
branch
from
23b8d32
to
edb08ce
Compare
|
Rebased on current main. |
davmac314
force-pushed
the
fix-gh-457
branch
from
edb08ce
to
15a927b
Compare
|
This change looks good and functions as advertised. |
|
At recent CDT calls we discussed how to handle reviews where there is insufficient expertise to review amongst existing committers and decided to accept such changes that look reasonable and appear sufficiently tested. |
jonahgraham
force-pushed
the
fix-gh-457
branch
from
15a927b
to
74d1288
Compare
jonahgraham
approved these changes
Dec 28, 2023
…mitive types Current partial specialisation selection matches deduced type by IBinding, not by IType, meaning that it can't work for types (such as primitive types) that aren't represented by an IBinding. Fix that by wrapping the result of resolution in a type which can handle either.
jonahgraham
force-pushed
the
fix-gh-457
branch
from
74d1288
to
0ccfe85
Compare
|
I needed to rebase manually due to conflicts with other recently merged changes. |
|
Thanks @jonahgraham ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current partial specialisation selection matches deduced type by IBinding, not by IType, meaning that it can't work for types (such as primitive types) that aren't represented by an IBinding. Fix that by wrapping the result of resolution in a type which can handle either.