Adds capability to display warnings in LaunchBar Launch Config Dialog #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a great test @betamaxbandit |
|
Failing SWTBot test added.
|
betamaxbandit
force-pushed
the
launchConfigWarnings
branch
3 times, most recently
from
c2a7e7a
to
ce3040f
Compare
jonahgraham
requested changes
Aug 7, 2024
...ipse.launchbar.ui/src/org/eclipse/launchbar/ui/internal/dialogs/NewLaunchConfigEditPage.java
Outdated
Show resolved
Hide resolved
Add SWTBot to test that the Launch Configuration, when opened via the Launch Bar, displays a warning in the message area. The Launch Bar Launch Configuration is, confusingly, handled by 2 different classes depending on whether a new configuration is being created (NewLaunchConfigEditPage) or edited (LaunchBarLaunchConfigDialog). When using NewLaunchConfigEditPage, the existing LaunchConfigurationTabGroupViewer.getWarningMessage() mechanism is used. This was added to eclipse-platform in Bug 386673 (commit 231ef13). When using LaunchBarLaunchConfigDialog (when editing), the new getWarningMessage() mechanism, copied from the existing, is used. In both classes above, logic was added to update the message when a tab change occurs.
betamaxbandit
force-pushed
the
launchConfigWarnings
branch
from
ce3040f
to
6a83794
Compare
|
Hi @jonahgraham , I've set this PR for review now. I don't think there's anything for me to do on it right now. Waiting for you. |
|
Hi @jonahgraham, do I need to do anything on this? Are you able to review this please? |
jonahgraham
approved these changes
Sep 12, 2024
|
Thanks @jonahgraham |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SWTBot to test that the Launch Configuration, when opened via the Launch Bar, displays a warning in the message area.
The launch config warnings functionality offered by [1] is now available to users of the Launch Bar.
[1] eclipse-platform/eclipse.platform@231ef13