From e715179f1de770b2d853b6aa37ed2bb2733c6de3 Mon Sep 17 00:00:00 2001 From: Alexander Fedorov Date: Fri, 7 Jul 2023 17:27:14 +0300 Subject: [PATCH 1/2] [#449] Import memory window is not working as expected Use `SWT.OPEN` style for import dialogs Signed-off-by: Alexander Fedorov --- .../cdt/debug/ui/memory/transport/PlainTextImporter.java | 4 ++-- .../cdt/debug/ui/memory/transport/RAWBinaryImporter.java | 4 ++-- .../cdt/debug/ui/memory/transport/SRecordImporter.java | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/memory/org.eclipse.cdt.debug.ui.memory.transport/src/org/eclipse/cdt/debug/ui/memory/transport/PlainTextImporter.java b/memory/org.eclipse.cdt.debug.ui.memory.transport/src/org/eclipse/cdt/debug/ui/memory/transport/PlainTextImporter.java index 8de863df91b..82e821a54b7 100644 --- a/memory/org.eclipse.cdt.debug.ui.memory.transport/src/org/eclipse/cdt/debug/ui/memory/transport/PlainTextImporter.java +++ b/memory/org.eclipse.cdt.debug.ui.memory.transport/src/org/eclipse/cdt/debug/ui/memory/transport/PlainTextImporter.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2006, 2020 Wind River Systems, Inc. and others. + * Copyright (c) 2006, 2023 Wind River Systems, Inc. and others. * * This program and the accompanying materials * are made available under the terms of the Eclipse Public License 2.0 @@ -157,7 +157,7 @@ public void widgetDefaultSelected(SelectionEvent e) { @Override public void widgetSelected(SelectionEvent e) { - FileDialog dialog = new FileDialog(parent.getShell(), SWT.SAVE); + FileDialog dialog = new FileDialog(parent.getShell(), SWT.OPEN); dialog.setText(Messages.getString("PlainTextImporter.ChooseFile")); //$NON-NLS-1$ dialog.setFilterExtensions(new String[] { "*.*;*" }); //$NON-NLS-1$ dialog.setFilterNames(new String[] { Messages.getString("Importer.AllFiles") }); //$NON-NLS-1$ diff --git a/memory/org.eclipse.cdt.debug.ui.memory.transport/src/org/eclipse/cdt/debug/ui/memory/transport/RAWBinaryImporter.java b/memory/org.eclipse.cdt.debug.ui.memory.transport/src/org/eclipse/cdt/debug/ui/memory/transport/RAWBinaryImporter.java index c7e36d74b01..c1ad100595c 100644 --- a/memory/org.eclipse.cdt.debug.ui.memory.transport/src/org/eclipse/cdt/debug/ui/memory/transport/RAWBinaryImporter.java +++ b/memory/org.eclipse.cdt.debug.ui.memory.transport/src/org/eclipse/cdt/debug/ui/memory/transport/RAWBinaryImporter.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2006, 2020 Wind River Systems, Inc. and others. + * Copyright (c) 2006, 2023 Wind River Systems, Inc. and others. * * This program and the accompanying materials * are made available under the terms of the Eclipse Public License 2.0 @@ -140,7 +140,7 @@ public void widgetDefaultSelected(SelectionEvent e) { @Override public void widgetSelected(SelectionEvent e) { - FileDialog dialog = new FileDialog(parent.getShell(), SWT.SAVE); + FileDialog dialog = new FileDialog(parent.getShell(), SWT.OPEN); dialog.setText(Messages.getString("RAWBinaryImporter.ChooseFile")); //$NON-NLS-1$ dialog.setFilterExtensions(new String[] { "*.*;*" }); //$NON-NLS-1$ dialog.setFilterNames(new String[] { Messages.getString("Importer.AllFiles") }); //$NON-NLS-1$ diff --git a/memory/org.eclipse.cdt.debug.ui.memory.transport/src/org/eclipse/cdt/debug/ui/memory/transport/SRecordImporter.java b/memory/org.eclipse.cdt.debug.ui.memory.transport/src/org/eclipse/cdt/debug/ui/memory/transport/SRecordImporter.java index 99dafba1ef6..2adf1444d8e 100644 --- a/memory/org.eclipse.cdt.debug.ui.memory.transport/src/org/eclipse/cdt/debug/ui/memory/transport/SRecordImporter.java +++ b/memory/org.eclipse.cdt.debug.ui.memory.transport/src/org/eclipse/cdt/debug/ui/memory/transport/SRecordImporter.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2006, 2020 Wind River Systems, Inc. and others. + * Copyright (c) 2006, 2023 Wind River Systems, Inc. and others. * * This program and the accompanying materials * are made available under the terms of the Eclipse Public License 2.0 @@ -194,7 +194,7 @@ public void widgetDefaultSelected(SelectionEvent e) { @Override public void widgetSelected(SelectionEvent e) { - FileDialog dialog = new FileDialog(parent.getShell(), SWT.SAVE); + FileDialog dialog = new FileDialog(parent.getShell(), SWT.OPEN); dialog.setText(Messages.getString("SRecordImporter.ChooseFile")); //$NON-NLS-1$ dialog.setFilterExtensions(new String[] { "*.*;*" }); //$NON-NLS-1$ dialog.setFilterNames(new String[] { Messages.getString("Importer.AllFiles") }); //$NON-NLS-1$ From 1710aa25a358f5c8876ae5bff7e783ec7cc26b3f Mon Sep 17 00:00:00 2001 From: Alexander Fedorov Date: Fri, 7 Jul 2023 17:42:49 +0300 Subject: [PATCH 2/2] [#449] Import memory window is not working as expected Increment version for org.eclipse.cdt.debug.ui.memory.transport Signed-off-by: Alexander Fedorov --- .../META-INF/MANIFEST.MF | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/memory/org.eclipse.cdt.debug.ui.memory.transport/META-INF/MANIFEST.MF b/memory/org.eclipse.cdt.debug.ui.memory.transport/META-INF/MANIFEST.MF index a458cf90f43..76e8ddcf3ea 100644 --- a/memory/org.eclipse.cdt.debug.ui.memory.transport/META-INF/MANIFEST.MF +++ b/memory/org.eclipse.cdt.debug.ui.memory.transport/META-INF/MANIFEST.MF @@ -2,7 +2,7 @@ Manifest-Version: 1.0 Bundle-ManifestVersion: 2 Bundle-Name: %pluginName Bundle-SymbolicName: org.eclipse.cdt.debug.ui.memory.transport;singleton:=true -Bundle-Version: 2.3.0.qualifier +Bundle-Version: 2.3.100.qualifier Bundle-Localization: plugin Bundle-Vendor: %providerName Require-Bundle: org.eclipse.cdt.debug.core.memory;bundle-version="0.1.0",