Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromatogram right-click menu immediately closes #540

Closed
Mailaender opened this issue Mar 23, 2021 · 3 comments
Closed

Chromatogram right-click menu immediately closes #540

Mailaender opened this issue Mar 23, 2021 · 3 comments

Comments

@Mailaender
Copy link
Contributor

I believe this happens because the right-click triggers an update (as seen in the console) of SWT Chart which then kills the menu. If you left-click on the chart first, wait a few seconds and then right-click the menu won't immediately close.

@eselmeister
Copy link
Contributor

Also have a look at this issue:
eclipse/swtchart#84

First of all, we should perform some further investigations to understand the problem.

@Mailaender
Copy link
Contributor Author

I narrowed it down already: close the Targets part and the problem is greatly reduced (but not completely gone). Add some logging and the madness reveals itself. There is an event loop between Targets and Chromatogram which fires a handful of events that take several seconds to process and they contain no actually changed items.

I also investigated eclipse/swtchart#84. It rebuilds the menu on update but removing the update on the menu manager (and only having a default SWT Chart menu) did not improve the situation at all. Also note that no other part shows that behavior. You can right-click on a scan chart and it won't close your context menu right away.

@eselmeister
Copy link
Contributor

See also:
eclipse/swtchart#243

eselmeister referenced this issue Mar 25, 2021
See propagateTarget which will already notify the UI.

Signed-off-by: Matthias Mailänder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants