Contract negotiation at 0.2.1

[galanisd]

We are building a connector based on EDC 0.2.1

I have created a controlplane-A and controlplane-B and tested the following scenario

• Created an asset, a policy and a Contract offer at controlplane-B
• Asked the catalog of B from A. Works as expected, i.e. receiving the following

{
	"@id": "a2345962-7767-4dac-8716-10a985c77133",
	"@type": "https://www.w3.org/ns/dcat/Catalog",
	"https://www.w3.org/ns/dcat/dataset": [
		{
			"@id": "5f740f42-a537-4cf2-9970-1aab9d6aee25",
			"@type": "https://www.w3.org/ns/dcat/Dataset",
			"odrl:hasPolicy": {
				"@id": "Mg==:NWY3NDBmNDItYTUzNy00Y2YyLTk5NzAtMWFhYjlkNmFlZTI1:NTNlNjMzN2YtMjg1Zi00MTc5LTgzYTAtZGQxMzE5Y2E1NDMy",
				"@type": "odrl:Set",
				"odrl:permission": {
					"odrl:target": "5f740f42-a537-4cf2-9970-1aab9d6aee25",
					"odrl:action": {
						"odrl:type": "http://www.w3.org/ns/odrl/2/use"
					},
					"odrl:constraint": {
						"odrl:and": [
							{
								"odrl:leftOperand": "https://w3id.org/edc/v0.0.1/ns/inForceDate",
								"odrl:operator": {
									"@id": "odrl:gteq"
								},
								"odrl:rightOperand": "2023-07-07T07:19:58.585601395Z"
							},
							{
								"odrl:leftOperand": "https://w3id.org/edc/v0.0.1/ns/inForceDate",
								"odrl:operator": {
									"@id": "odrl:lteq"
								},
								"odrl:rightOperand": "2023-07-12T07:19:58.585601395Z"
							}
						]
					}
				},
				"odrl:prohibition": [
				],
				"odrl:obligation": [
				],
				"odrl:target": "5f740f42-a537-4cf2-9970-1aab9d6aee25"
			},
			"https://www.w3.org/ns/dcat/distribution": [
			],
			"ms:anonymized": {
				"@id": "ms:noA"
			},
			"ms:annotationType": {
				"@id": "http://w3id.org/meta-share/omtd-share/Stem"
			},
			"dct:description": [
				{
					"@value": "a nice description for a very nice corpus",
					"@language": "en"
				},
				{
					"@value": "ένα πολύ ωραίο σύνολο δεδομένων",
					"@language": "el"
				}
			],
			"ms:iprHolder": {
				"@id": "https://lds.eu/ILSPh",
				"@type": "foaf:Agent",
				"foaf:name": [
					{
						"@value": "ILSP",
						"@language": "en"
					},
					{
						"@value": "ILSPS",
						"@language": "el"
					}
				],
				"dct:identifier": "testId1"
			},
			"ms:isDocumentedBy": {
				"@id": "https://lds.eu/mydoc",
				"@type": "foaf:Document",
				"dct:title": {
					"@value": "my doc",
					"@language": "en"
				},
				"dct:description": {
					"@value": "my doc description",
					"@language": "en"
				}
			},
			"dct:publisher": {
				"@id": "https://lds.eu/ILSP",
				"@type": "foaf:Agent",
				"foaf:name": [
					{
						"@value": "ILSP",
						"@language": "en"
					},
					{
						"@value": "ILSPs",
						"@language": "el"
					}
				],
				"dct:identifier": "testId1"
			},
			"dcat:version": "1.0.0",
			"dct:language": {
				"@id": "http://publications.europa.eu/resource/authority/language/DEU"
			},
			"ms:domain": {
				"@id": "http://publications.europa.eu/resource/authority/data-theme/AGRI"
			},
			"dct:identifier": "testId1",
			"ms:corpusSubclass": {
				"@id": "ms:rawCorpus"
			},
			"https://www.w3.org/TR/vocab-adms/identifier": "testId3",
			"ms:personalDataIncluded": {
				"@id": "ms:noP"
			},
			"ms:multilingualityType": {
				"@id": "ms:parallel"
			},
			"ms:sensitiveDataDetails": {
				"@value": "sensitive Data Details",
				"@language": "en"
			},
			"ms:personalDataDetails": {
				"@value": "personal Data Details",
				"@language": "en"
			},
			"dct:alternative": {
				"@value": "alternative",
				"@language": "en"
			},
			"ms:mediaType": {
				"@id": "ms:text"
			},
			"ms:lingualityType": {
				"@id": "ms:bilingual"
			},
			"dct:title": {
				"@value": "title",
				"@language": "en"
			},
			"dct:license": {
				"@type": "dct:LicenseDocument",
				"@id": "ms:CC-BY4"
			},
			"ms:sensitiveDataIncluded": {
				"@id": "ms:noS"
			},
			"ms:cost": {
				"ms:amount": 998.01,
				"ms:currency": {
					"@id": "ms:euro"
				}
			},
			"ms:language": [
				{
					"@id": "loc:de"
				},
				{
					"@id": "loc:el"
				}
			],
			"ms:lrType": {
				"@id": "ms:Corpus"
			},
			"dcat:distribution": {
				"@type": "dcat:Distribution",
				"ms:size": [
					{
						"ms:amount": 100,
						"ms:sizeUnit": {
							"@id": "ms:sentence1"
						}
					},
					{
						"ms:amount": 200,
						"ms:sizeUnit": {
							"@id": "ms:translationUnit"
						}
					}
				],
				"dcat:packageFormat": {
					"@id": "https://lds.eu/szip",
					"@type": "dct:MediaType"
				},
				"dcat:byteSize": 300254687,
				"dcat:downloadURL": {
					"@id": "https://lds.eu/http//www.example.com"
				},
				"dcat:accessURL": {
					"@id": "https://lds.eu/http//www.example.com"
				},
				"dcat:mediaType": {
					"@id": "http://www.iana.org/assignments/media-types/application/zip"
				}
			},
			"dct:temporal": {
				"@type": "dct:PeriodOfTime",
				"dcat:startDate": {
					"@value": "1998-01-01",
					"@type": "http://www.w3.org/2001/XMLSchema#date"
				},
				"dcat:endDate": {
					"@value": "1998-01-02",
					"@type": "http://www.w3.org/2001/XMLSchema#date"
				}
			},
			"ms:anonymizationDetails": {
				"@value": "anonymization Details",
				"@language": "en"
			},
			"edc:id": "5f740f42-a537-4cf2-9970-1aab9d6aee25",
			"dcat:keyword": {
				"@value": "corpus",
				"@language": "en"
			}
		}
	],
	"https://www.w3.org/ns/dcat/service": {
		"@id": "5292a104-3107-4ba4-9276-d315e52fe6b4",
		"@type": "https://www.w3.org/ns/dcat/DataService",
		"dct:terms": "connector",
		"dct:endpointUrl": "http://localhost:8282/api/v1/ids"
	},
	"edc:participantId": "urn:connector:edc1",
	"@context": {
		"loc": "http://id.loc.gov/vocabulary/iso639-1/",
		"dct": "https://purl.org/dc/terms/",
		"edc": "https://w3id.org/edc/v0.0.1/ns/",
		"ms": "http://w3id.org/meta-share/meta-share/",
		"dcat": "http://www.w3.org/ns/dcat/",
		"odrl": "http://www.w3.org/ns/odrl/2/",
		"foaf": "http://xmlns.com/foaf/0.1/",
		"dspace": "https://w3id.org/dspace/v0.8/"
	}
}

Then based on the received catalog I am initiating a Contract Negotiation to A (/v2/contractnegotiations)
with the following message

{
	"@context": {
		"edc": "https://w3id.org/edc/v0.0.1/ns/",
		"odrl": "http://www.w3.org/ns/odrl/2/"
	},
	"@type": "ContractRequest",
	"connectorId": "urn:connector:edc1",
	"connectorAddress": "http://localhost:8282/api/v1/ids",
	"consumerId": "urn:connector:edc2",
	"providerId": "urn:connector:edc1",
	"protocol": "dataspace-protocol-http",
	"offer": {
		"offerId": "Mg==:NWY3NDBmNDItYTUzNy00Y2YyLTk5NzAtMWFhYjlkNmFlZTI1:NzM2NTllNDgtMWM5ZS00MDJmLWEwYTMtMzM1MTAxNDY0NmZl",
		"assetId": "5f740f42-a537-4cf2-9970-1aab9d6aee25",
		"policy": {
			"@id": "Mg==:NWY3NDBmNDItYTUzNy00Y2YyLTk5NzAtMWFhYjlkNmFlZTI1:NzM2NTllNDgtMWM5ZS00MDJmLWEwYTMtMzM1MTAxNDY0NmZl",
			"@type": "odrl:Set",
			"odrl:permission": {
				"odrl:target": "5f740f42-a537-4cf2-9970-1aab9d6aee25",
				"odrl:action": {
					"odrl:type": "http://www.w3.org/ns/odrl/2/use"
				},
				"odrl:constraint": {
					"odrl:and": [
						{
							"odrl:leftOperand": "https://w3id.org/edc/v0.0.1/ns/inForceDate",
							"odrl:operator": {
								"@id": "odrl:gteq"
							},
							"odrl:rightOperand": "2023-07-07T07:19:58.585601395Z"
						},
						{
							"odrl:leftOperand": "https://w3id.org/edc/v0.0.1/ns/inForceDate",
							"odrl:operator": {
								"@id": "odrl:lteq"
							},
							"odrl:rightOperand": "2023-07-12T07:19:58.585601395Z"
						}
					]
				}
			},
			"odrl:prohibition": [],
			"odrl:obligation": [],
			"odrl:target": "5f740f42-a537-4cf2-9970-1aab9d6aee25"
		}
	}
}

In turn A communicates with B
which receives a message at the DspNegotiationApiController

There I am getting the following error. It happens while validating this offer

java.lang.IllegalStateException: Object has already been returned to this pool or is invalid
	at org.apache.commons.pool2.impl.BaseGenericObjectPool.markReturningState(BaseGenericObjectPool.java:1251)
	at org.apache.commons.pool2.impl.GenericObjectPool.returnObject(GenericObjectPool.java:1029)
	at org.eclipse.edc.sql.pool.commons.CommonsConnectionPool.returnConnection(CommonsConnectionPool.java:76)
	at org.eclipse.edc.sql.datasource.PooledDataSourceConnection.close(PooledDataSourceConnection.java:96)
	at org.eclipse.edc.connector.store.sql.assetindex.SqlAssetIndex.countAssets(SqlAssetIndex.java:170)
	at org.eclipse.edc.connector.contract.validation.ContractValidationServiceImpl.validateInitialOffer(ContractValidationServiceImpl.java:184)
	at org.eclipse.edc.connector.contract.validation.ContractValidationServiceImpl.lambda$validateInitialOffer$1(ContractValidationServiceImpl.java:90)
	at org.eclipse.edc.spi.result.AbstractResult.compose(AbstractResult.java:169)
	at org.eclipse.edc.connector.contract.validation.ContractValidationServiceImpl.validateInitialOffer(ContractValidationServiceImpl.java:87)
	at org.eclipse.edc.connector.contract.validation.ContractValidationServiceImpl.validateInitialOffer(ContractValidationServiceImpl.java:81)
	at org.eclipse.edc.connector.service.contractnegotiation.ContractNegotiationProtocolServiceImpl.validateOffer(ContractNegotiationProtocolServiceImpl.java:186)
	at org.eclipse.edc.connector.service.contractnegotiation.ContractNegotiationProtocolServiceImpl.lambda$notifyRequested$4(ContractNegotiationProtocolServiceImpl.java:71)
	at org.eclipse.edc.transaction.spi.NoopTransactionContext.execute(NoopTransactionContext.java:34)
	at org.eclipse.edc.connector.service.contractnegotiation.ContractNegotiationProtocolServiceImpl.notifyRequested(ContractNegotiationProtocolServiceImpl.java:71)
	at org.eclipse.edc.protocol.dsp.negotiation.api.controller.DspNegotiationApiController.validateAndProcessRequest(DspNegotiationApiController.java:326)
	at org.eclipse.edc.protocol.dsp.negotiation.api.controller.DspNegotiationApiController.handleMessage(DspNegotiationApiController.java:318)
	at org.eclipse.edc.protocol.dsp.negotiation.api.controller.DspNegotiationApiController.initiateNegotiation(DspNegotiationApiController.java:135)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

Is this a bug or I am doing something wrong? If it is a bug is it possible that it happens because
in this line https://github.com/eclipse-edc/Connector/blob/df1276c036f7acf217fc6197a0866db5655b9d9b/extensions/control-plane/store/sql/asset-index-sql/src/main/java/org/eclipse/edc/connector/store/sql/assetindex/SqlAssetIndex.java#L169C20-L169C33

single has to close the connection?

[galanisd]

I called the same function from another point in the code; i.e., a REST endpoint that I have created with an extension

....
		ArrayList<Criterion>testCriteria = new ArrayList<>();
		testCriteria.add(new Criterion(Asset.PROPERTY_ID, "=", "1"));
		index.countAssets(testCriteria);
...

and I am gettting the same stack of errors

java.lang.IllegalStateException: Object has already been returned to this pool or is invalid
	at org.apache.commons.pool2.impl.BaseGenericObjectPool.markReturningState(BaseGenericObjectPool.java:1251)
	at org.apache.commons.pool2.impl.GenericObjectPool.returnObject(GenericObjectPool.java:1029)
	at org.eclipse.edc.sql.pool.commons.CommonsConnectionPool.returnConnection(CommonsConnectionPool.java:76)
	at org.eclipse.edc.sql.datasource.PooledDataSourceConnection.close(PooledDataSourceConnection.java:96)
	at org.eclipse.edc.connector.store.sql.assetindex.SqlAssetIndex.countAssets(SqlAssetIndex.java:170)
	at eu.lds.edc.connector.service.asset.AssetServiceImplLDS.create(AssetServiceImplLDS.java:84)
	at eu.lds.edc.api.management.asset.AssetApiControllerLDS.createAsset(AssetApiControllerLDS.java:93)

[galanisd]

@ndr-brt any comments on the above?
Sorry for asking again, but it is somewhat blocking.
Thanks in advance!

[ndr-brt]

looking at the stacktrace you provided:

at org.eclipse.edc.transaction.spi.NoopTransactionContext.execute(NoopTransactionContext.java:34)

you are using a noop transaction context, that is meant only for testing purpose, please use at least the local implementation (transaction-local module)

[galanisd]

Yes, I know. I solved the problem 2 days ago by doing exactly what you said (using local transaction module).
A relevant warning for no-op transactions on startup helped me. Maybe the warning should somehow say more explicitly that using noop transaction module results in some functionalities not working as expected.